From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 1ecd350 2/2: Evaluate some unnecessarily quoted lambdas Date: Sun, 21 Jun 2020 12:18:50 -0400 Message-ID: References: <20200621124626.3690.70321@vcs0.savannah.gnu.org> <20200621124629.C414420A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37470"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 21 18:19:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jn2h5-0009fc-Ra for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 18:19:43 +0200 Original-Received: from localhost ([::1]:41520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn2h4-0005Z1-Uu for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 12:19:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn2gL-00051M-HW for emacs-devel@gnu.org; Sun, 21 Jun 2020 12:18:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn2gI-0007LL-W0 for emacs-devel@gnu.org; Sun, 21 Jun 2020 12:18:56 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0929580D86; Sun, 21 Jun 2020 12:18:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2C5F080A02; Sun, 21 Jun 2020 12:18:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1592756331; bh=MUq8+IjFTY+kgHM7YMga26J4JQUpXzuqoRPNJcGglCI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DaMFChOnkscRM9N43jARHQhKlvIMfnULFXjfGQnUykFNrvF937lp8IR51axMmsbiL 7WY5yTeQwIptRVLsBprYSuXGIer6OISSvADaaxbQHenthBAesLIxPg7HMrl3D7SUqI fXN71Q5/YxLvCKTgvtjJ+TizhAQOleEzt+6qx97tDLbFUjKmhxRiWGiy+7DotpEUtk jznYYRe3pcGo2g2IzBpxq/QxAcJdsQqB9zhdpkblvaYFkGSDAriQF4/cLkataL7f4P sG00FEc3EE0CM9fTJE1F6nWnKs2Hy1lJ2LW91YP4poaqIpZLmQmuX+jCoqJXZlzIvS 6Mylp19kNk8uQ== Original-Received: from alfajor (unknown [108.175.228.207]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E272D120460; Sun, 21 Jun 2020 12:18:50 -0400 (EDT) In-Reply-To: <20200621124629.C414420A26@vcs0.savannah.gnu.org> (Basil L. Contovounesios's message of "Sun, 21 Jun 2020 08:46:29 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/21 12:18:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252495 Archived-At: > - (lambda-code (byte-compile '(lambda ())))) > + (lambda-code (byte-compile (lambda ())))) I can't believe I'm doing that, but: this hunk is wrong! `byte-compile` takes source code as input, not values. It does go to the trouble of trying to handle the case where we pass it a function value that's not yet compiled because it's an important use-case in practice, but it's better to avoid it since the above means that we'll first turn '(lambda () ()) into a closure object which `byte-compile` then has to convert back to something like (lambda () ()). Stefan