Re: master 2644353: * .gitignore: add src/fingerprint.c

Re: master 2644353: * .gitignore: add src/fingerprint.c

[Glenn Morris]

Stephen Leake wrote:

> branch: master
> commit 2644353cbc65927a6a0a76d68e00d017771cdd03

>     * .gitignore: add src/fingerprint.c

Why? It's not generated since 2019-04-09.
Ref b697bb91a1

Re: master 2644353: * .gitignore: add src/fingerprint.c

[Stefan Monnier]

>> branch: master
>> commit 2644353cbc65927a6a0a76d68e00d017771cdd03
>
>>     * .gitignore: add src/fingerprint.c
>
> Why? It's not generated since 2019-04-09.
> Ref b697bb91a1

BTW, this is a recurring problem: every time we change our build
procedure such that an intermediate file isn't built any more,
someone ends up (re)adding it to `.gitignore`.


        Stefan

Re: master 2644353: * .gitignore: add src/fingerprint.c

[Stephen Leake]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> branch: master
>>> commit 2644353cbc65927a6a0a76d68e00d017771cdd03
>>
>>>     * .gitignore: add src/fingerprint.c
>>
>> Why? It's not generated since 2019-04-09.
>> Ref b697bb91a1
>
> BTW, this is a recurring problem: every time we change our build
> procedure such that an intermediate file isn't built any more,
> someone ends up (re)adding it to `.gitignore`.

Ah; I had fingerprint.c left over from some previous build, and did not
check that it is still generated.

I'll try to remember to check that in the future.

And to remember that other people keep .gitignore up to date, so a
previously generated file showing up means I should just delete it.

-- 
-- Stephe

Re: master 2644353: * .gitignore: add src/fingerprint.c

[Stefan Monnier]

>> BTW, this is a recurring problem: every time we change our build
>> procedure such that an intermediate file isn't built any more,
>> someone ends up (re)adding it to `.gitignore`.
[...]
> I'll try to remember to check that in the future.

I don't think it'll help: I made the same mistake in the past as have
several others, then we learned, now you're learning as well but next
time around there'll be inevitably someone else who hasn't learned
it yet.


        Stefan

Re: master 2644353: * .gitignore: add src/fingerprint.c

[Basil L. Contovounesios]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> BTW, this is a recurring problem: every time we change our build
>>> procedure such that an intermediate file isn't built any more,
>>> someone ends up (re)adding it to `.gitignore`.
> [...]
>> I'll try to remember to check that in the future.
>
> I don't think it'll help: I made the same mistake in the past as have
> several others, then we learned, now you're learning as well but next
> time around there'll be inevitably someone else who hasn't learned
> it yet.

Would a comment at the top of the file help, or is that too easily
missed?

-- 
Basil

Re: master 2644353: * .gitignore: add src/fingerprint.c

[Robin Tarsiger]

Stefan Monnier wrote:
> I don't think it'll help: I made the same mistake in the past as have
> several others, then we learned, now you're learning as well but next
> time around there'll be inevitably someone else who hasn't learned
> it yet.

I would suggest that when a file transitions from generated to
source, it gains a negated entry in a section at the end of .gitignore
which is commented to this effect. That way, someone editing the file
at the end will see the negation section and be reminded to
slow down and check it, and someone editing an earlier section will
find that the effect is canceled out and be encouraged to pause and
look around for why.

(These can be pruned after some time if the section becomes large,
of course.)

-RTT