From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master e315544: ; * src/fileio.c (Fdirectory_append): Doc fix. Date: Sun, 25 Jul 2021 01:27:34 -0400 Message-ID: References: <20210724171858.1726.43078@vcs0.savannah.gnu.org> <20210724171900.4A26D20D0A@vcs0.savannah.gnu.org> <87h7gjo8sh.fsf@gmx.de> <871r7n1r6a.fsf@gnus.org> <87zgubmt3z.fsf@gmx.de> <87wnpfynqn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Albinus , Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 25 07:29:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7WhA-0008vt-D4 for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Jul 2021 07:29:00 +0200 Original-Received: from localhost ([::1]:34894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Wh9-0000k0-F9 for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Jul 2021 01:28:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Wfu-0008Tc-7z for emacs-devel@gnu.org; Sun, 25 Jul 2021 01:27:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Wfr-0008FF-1N; Sun, 25 Jul 2021 01:27:41 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 93BA54402E1; Sun, 25 Jul 2021 01:27:36 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 852BB440221; Sun, 25 Jul 2021 01:27:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1627190855; bh=B52Pb3d+sjqGWqoeznAx4X4eubPBwQs9GUZeTc2IbPI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nc3/HoLUgjAYGGJXnxJYEuVnujcjfom7QS88rCEeAr7prXEKLEXUIvRjoebKg2bLB eVaFGMdLaGCinGfs2o7Yqpr9x+l5S1h6nagcfEW6F2MjW9jZQ2Fk1MtavZb1aDF/e2 wzR20wO84YP8TKxE07FK+Q68K/hNZF97L3uENx8tEIhFDIs2akwnGfOLHqiK13xPgX a01fefCCxhtUlG8gAoTj2ixxwUBpLHlK/wI6a8PN9Vw8QxiIOburM6Uqgvs4Cwqs1u M0hdUJmkvGoah3y+S9jqYKE/OnywwwX+xGRqv9mpxYVI9QzTT/X0WY2dlde/npsZnW KlmyRjWuFInsQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 308E212014D; Sun, 25 Jul 2021 01:27:35 -0400 (EDT) In-Reply-To: <87wnpfynqn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 25 Jul 2021 07:19:12 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271582 Archived-At: > By the way -- I'm not sure that `directory-append' is the best function > name here... `file-name-concat' would perhaps be more natural? But > it's really about directories... `directory-name-concat'? Hm. I vote for `file-name-concat` (while some of the arguments are directory names, the last one usually/often isn't and neither is the return value). Stefan