From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#19342: auto-fill scan-error in sh-mode Date: Fri, 06 May 2022 10:12:21 -0400 Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Glenn Morris , 19342@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 06 16:13:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmyht-0005DM-ND for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 May 2022 16:13:21 +0200 Original-Received: from localhost ([::1]:41734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmyhs-0001CT-Ro for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 May 2022 10:13:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmyha-0001CI-Qc for bug-gnu-emacs@gnu.org; Fri, 06 May 2022 10:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmyha-0001RV-Eo for bug-gnu-emacs@gnu.org; Fri, 06 May 2022 10:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmyha-0000SL-AU for bug-gnu-emacs@gnu.org; Fri, 06 May 2022 10:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2022 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19342 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 19342-submit@debbugs.gnu.org id=B19342.16518463521716 (code B ref 19342); Fri, 06 May 2022 14:13:02 +0000 Original-Received: (at 19342) by debbugs.gnu.org; 6 May 2022 14:12:32 +0000 Original-Received: from localhost ([127.0.0.1]:49347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmyh6-0000Rc-2s for submit@debbugs.gnu.org; Fri, 06 May 2022 10:12:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmyh4-0000RQ-HT for 19342@debbugs.gnu.org; Fri, 06 May 2022 10:12:31 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C59C710029F; Fri, 6 May 2022 10:12:24 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 91BC710012C; Fri, 6 May 2022 10:12:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651846342; bh=Ow1eJ8IPlJtYJs4+m5taSU0Smr7zU8oQCs66vMxfdYk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gPoWUREjsh5EfLGLJLLqzIcCRF+odchZifnTGmhkEJS3euNUFyNjb+oO2RuQbnAyS KA0gnKZIn45CeGbDBjokqtNqt1C+i0xl6oXDhfRvb1zbTIRQzP6zlzKewvrrGVtGlG IaRkEcqOwQ7pHZe/haaMMK2PIztB8pyeiP3x3MqbuIg4SrN+wVX38mdKEWS5BBtZp9 Pewed4llOPfvCQqLrGmTzOQmhpjRRCWfo/Obeyx4TrHkbbXz2l+BlwmlaDWlVMFVfD sIAjnNKnJnZS+eFyGiJzETxD/K8v9l5I+q3IUjeuWJzsUkgyBKYaJJbkpdHDffu/1d wVuqraE7s9Z1A== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 59A1312080E; Fri, 6 May 2022 10:12:22 -0400 (EDT) In-Reply-To: <878s0i76ek.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 31 Aug 2021 03:24:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231514 Archived-At: Lars Ingebrigtsen [2021-08-31 03:24:35] wrote: > Stefan Monnier writes: >> It's not issuing an error. It's emitting a message, the purpose >> of which is to warn the user that the behavior was affected by >> that problem. > > I get your point, and as you say, it works fine -- it auto-fills as it's > supposed to. > > But it's literally signalling an error. (And this is one of those rare > instances where "literally" isn't a general intensifier.) Changing it > to a message would solve the issue, I think? BTW, AFAICT it does not *literally* signal an error: the error is caught inside `smie-auto-fill` and turned into a message (by `with-demoted-errors`). So if we want to silence the message, all it takes is to use `ignore-error` instead as in the patch below, no? Stefan diff --git a/lisp/emacs-lisp/smie.el b/lisp/emacs-lisp/smie.el index 2bab1319132..2be1ca3218b 100644 --- a/lisp/emacs-lisp/smie.el +++ b/lisp/emacs-lisp/smie.el @@ -1846,7 +1846,7 @@ smie-auto-fill (move-to-column fc) (syntax-ppss)))) (while - (and (with-demoted-errors "SMIE Error: %S" + (and (ignore-error scan-error (save-excursion (let ((end (point)) (bsf nil) ;Best-so-far.