From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: master 40c0124816: Minor improvements to precision scroll interpolation
Date: Sat, 30 Jul 2022 03:27:44 -0400 [thread overview]
Message-ID: <jwv35ej6p1k.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8335ej6t0v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Jul 2022 08:58:40 +0300")
>> --- a/lisp/pixel-scroll.el
>> +++ b/lisp/pixel-scroll.el
>> @@ -759,6 +759,9 @@ It is a vector of the form [ VELOCITY TIME SIGN ]."
>> (interactive "e")
>> (when pixel-scroll-precision-use-momentum
>> (let ((window (mwheel-event-window event))
>> + ;; The animations are smoother if the GC threshold is
>> + ;; reduced for the duration of the animation.
>> + (gc-cons-threshold (* gc-cons-threshold 3))
>> (state nil))
>
> I don't think it is safe to multiply gc-cons-threshold without some
> kind of limitation from above: the user or some Lisp program could
> have increased the threshold already to a large value.
And I also suspect the above won't be "sufficient" when the heap is
large, because in that case `gc-cons-threshold` doesn't have any effect
any more and it's `gc-cons-percentage` that matters instead.
Maybe binding `gc-cons-percentage` to something like the 1.0 value we
now use in batch mode (or rather to (max 1.0 gc-cons-percentage)) would
be a better option.
Stefan
prev parent reply other threads:[~2022-07-30 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 5:58 master 40c0124816: Minor improvements to precision scroll interpolation Eli Zaretskii
2022-07-30 7:03 ` Po Lu
2022-07-30 7:27 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv35ej6p1k.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.