From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 629f980fad: Enhance safe_run_hooks_1 and safe_run_hook_funcall to handle more arguments Date: Mon, 15 Aug 2022 10:28:56 -0400 Message-ID: References: <166056597907.22106.4183994272552532983@vcs2.savannah.gnu.org> <20220815121939.5CBCBC0F1F3@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Alan Mackenzie To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 15 17:34:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNc6M-0006eX-LV for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Aug 2022 17:34:02 +0200 Original-Received: from localhost ([::1]:45666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNc6K-0008WF-WA for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Aug 2022 11:34:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNb5w-0003N5-0j for emacs-devel@gnu.org; Mon, 15 Aug 2022 10:29:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNb5t-0004tE-PJ for emacs-devel@gnu.org; Mon, 15 Aug 2022 10:29:31 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F161C100138; Mon, 15 Aug 2022 10:29:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7AD1910002A; Mon, 15 Aug 2022 10:29:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660573767; bh=VBlTZbwQedvvq6XnYJusTSxpQ5ieYULxRSv/oDkXYHM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z32WLmBkrVNh1M248K5O3pQfAzUi3zHB9zDngTz80JKBuQWVBrIO16/IOqlEhT2Gk Cq7pRv9KvwxwnPl91rkL2TS3Mb0ODN7q30q6FgALNPW/go8E4XCeJFgv27XcmGRPL0 Au3EGMJxAvK8cVxA6UIrKWA/7icVmCz++3YcQGSOgU6Ya+Rl1bnA6cBkVVPK15w+1K 0upOdJOYX17UI+c4os+PLXRdpa4aNIh3h9cWi3iUrSzlYRT65wir69T3uZtgQucOG9 O4YV1iEdcDnb33RlO1MMRAqAHSDBmGY9J3coUmvEtZj87KVzdOAWfmW6SFshn1swGH NWZjpSh4XNLEg== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 49E3312016F; Mon, 15 Aug 2022 10:29:27 -0400 (EDT) In-Reply-To: <20220815121939.5CBCBC0F1F3@vcs2.savannah.gnu.org> (Alan Mackenzie's message of "Mon, 15 Aug 2022 08:19:39 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293483 Archived-At: > static Lisp_Object > safe_run_hooks_1 (ptrdiff_t nargs, Lisp_Object *args) > { > - eassert (nargs == 2); > - return call0 (args[1]); > + eassert (nargs >= 2 && nargs <= 4); > + switch (nargs) > + { > + case 2: > + return call0 (args[1]); > + case 3: > + return call1 (args[1], args[2]); > + default: > + return call2 (args[1], args[2], args[3]); > + } > } Can't we do something like return Ffuncall (nargs - 1, args + 1); ? Stefan