From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Average-user-facing interface for tree-sitter Date: Tue, 18 Oct 2022 18:31:10 -0400 Message-ID: References: <3A7E7CD1-74A7-4352-9DFE-FC982EAA398E@gmail.com> <87ilko9r9e.fsf@gnus.org> <9794E2EF-4DB5-4A04-90F0-3EB51E6BE008@gmail.com> <87977C2D-844B-4F4E-BEA4-8BCBFC8AE354@gmail.com> <6A0F847F-910D-449B-B461-466493CC9847@gmail.com> <87sfjmg69q.fsf@gnus.org> <21B2ADDF-70BC-46D4-98D6-41C5D0EF7D40@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17883"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 19 00:33:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okv8y-0004Rj-UA for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 00:33:05 +0200 Original-Received: from localhost ([::1]:42108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okv8x-0000ax-Ew for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Oct 2022 18:33:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okv7G-00081h-7w for emacs-devel@gnu.org; Tue, 18 Oct 2022 18:31:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okv7E-0007yN-FQ for emacs-devel@gnu.org; Tue, 18 Oct 2022 18:31:18 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B561180796; Tue, 18 Oct 2022 18:31:14 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1AB5A803F2; Tue, 18 Oct 2022 18:31:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666132273; bh=zTlK2/HA0Lehw2i72BCVz6me/D3ZhrY/UY8iwoe+K0M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GCf4KFXEptkbORkTDdaYf2/x2HHHOWzMoJUNFGVbRG4Q1ZMo8LOs8xQ2FCBiv76c8 Id6BpLWgfhfeOxXDOirPl8vm02C1PuZQVWkdzPAV2KGV8IWTvYCLvKTY9FGFUWDcgk 9bH67TvYHYBmUMgnaYGeDlkJGJHLUkbPuOEI1RmvC69fzpmKVw3fhWyUUjytNFwPth eNSdeSNG6MXXyL54kIpWAsotb0+9EOdU9v/DKfk50D4l5hHE2yzLJDpXjUEtSt7Fvm QN6ftKoN56McHBybyDwIvUQyssYlMp2o1HeyVTZkNLdhTuabEP+QWE2ZM0AN88pmxB ws29Fu8QpgTeQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 08592120F35; Tue, 18 Oct 2022 18:31:13 -0400 (EDT) In-Reply-To: (Yuan Fu's message of "Tue, 18 Oct 2022 15:06:12 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298089 Archived-At: >> Too much magic, IMO. Let each case handle it manually, since I suspect >> that every case will be different and the best thing to do will vary (it >> depends on whether the two modes are still actively maintained, whether >> by the same authors or not, the relative age and popularity of the >> respective modes, =E2=80=A6) > > So we don=E2=80=99t do anything in global-treesit-mode? Ie, > > (define-globalized-minor-mode global-treesit-mode treesit-mode > global-treesit-mode--turn-on > :version "29.1" > :group 'treesit > :predicate t > (when (not global-treesit-mode) > (dolist (map treesit-remapped-major-mode-alist) > (setq major-mode-remap-alist > (remove map major-mode-remap-alist))))) > > to > > (define-globalized-minor-mode global-treesit-mode treesit-mode > global-treesit-mode--turn-on > :version "29.1" > :group 'treesit > :predicate t > ) > > And remove treesit-remapped-major-mode-alist? That's I'd do, yes. It's much easier to add features later (if they prove to satisfy a common need) than to remove unused features. BTW, I see that `global-treesit-mode--turn-on` is currently a (non official) alias of `treesit-mode`, but I think it should only call `treesit-mode` in those buffers where there is some indication that the major mode provides some treesit-mode support (e.g., currently that could be if `major-mode-backend-function` is set). And then maybe `treesit-mode` should signal an error (and turn itself off) if it's enabled in a buffer whose major mode does not provide any support for `treesit-mode`. Stefan