all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Matt Armstrong <matt@rfc20.org>, 59029@debbugs.gnu.org
Subject: bug#59029: Dumping Emacs crashes when buffers have overlays
Date: Tue, 08 Nov 2022 12:21:24 -0500	[thread overview]
Message-ID: <jwv35attlj0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83cz9xxtzi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Nov 2022 18:59:29 +0200")

>> a) Drop support for dumping overlays in buffers, as if
>> `delete-all-overlays' were called for all buffers before dumping.  Fix
>> involves relaxing the abort() calls to merely print warnings.
>> 
>> b) Restore support, and test it.
>
> a) could be a short-term band-aid, but if we want ever to support
> re-dumping, b) is a must.

FWIW, I suspect that the vast majority of redumping uses will/would be
to include more preloaded ELisp code rather than to include
pre-populated buffers, so it's quite likely that it would work just fine
without that extra support for dumping overlays-in-buffers.

But I agree that (b) is a must, because I find it sad if we can't get
the pdumping code working.

>> For (b) I'm not keen on wiring up a single-purpose test under test/*
>> somewhere just to test pdumping with overlays.  How about hooking in to
>> loadup.el to populate a dummy buffer with overlays before dumping?
> For testing purposes, you could perhaps use eval-after-load to do
> something after loading loadup.el?

IMO, we should have a proper separate pdump test, instead.


        Stefan






  reply	other threads:[~2022-11-08 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 23:09 bug#59029: 29.0.50; noverlay: pdumper.c: dump_interval_node recursion has no base case Matt Armstrong
2022-11-05  5:41 ` Gerd Möllmann
2022-11-05 18:09   ` Matt Armstrong
2022-11-06  5:21     ` Gerd Möllmann
2022-11-05 20:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-08 15:59   ` bug#59029: Dumping Emacs crashes when buffers have overlays Matt Armstrong
2022-11-08 16:59     ` Eli Zaretskii
2022-11-08 17:21       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-09 20:04         ` Matt Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv35attlj0.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59029@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=matt@rfc20.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.