From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals-release/org e2366ac283: * lisp/org-persist.el: Do not litter /tmp when native compiling Date: Wed, 21 Dec 2022 14:07:48 -0500 Message-ID: References: <167164907706.9937.9724677162932540750@vcs2.savannah.gnu.org> <20221221185757.74391C00613@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ihor Radchenko To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 21 20:08:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p84Ru-0008to-OH for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Dec 2022 20:08:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p84Ra-0004nV-0D; Wed, 21 Dec 2022 14:07:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p84RY-0004nN-Cd for emacs-devel@gnu.org; Wed, 21 Dec 2022 14:07:56 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p84RW-00070Q-KC for emacs-devel@gnu.org; Wed, 21 Dec 2022 14:07:56 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C2F521000CC; Wed, 21 Dec 2022 14:07:51 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E47511000E8; Wed, 21 Dec 2022 14:07:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671649669; bh=wfqOphSjNdkde5Zc6XUd96g32h47uTf2X9Uudmct2kw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=mA3zzjqtxUqjFZatnUmhw0e5qfv3mJEdfjT1EwMHOYtao9hrAoVNmNwYoX8Kc7Pwz Q4hxUcqYz3M9op5i5hlOIWkSAqL4EzrQtUllD0EZptQxWIVn4k9wEw5POKCC9XqJUs BMXvI4CfNkz9OagNlXzjLu7VOlgDhiYNl5lMqS8iKcgsPIS9s6B5ZxdEJu2/O1Da7J k1j4irBj1NuoDUkKr1cEi312tFVbu1uUxlZwHG1EEWLQ/KWhjpPyBBUNG9ZvumJDVv Wu/2xOw6bfb4DDI0MTTLvTgglCmxoymOJuEjBEXrca+OQUjHDAtKAJ+F9ZjTjbyuat NvMHNlhiYnmKA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D490B1200FC; Wed, 21 Dec 2022 14:07:49 -0500 (EST) In-Reply-To: <20221221185757.74391C00613@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Wed, 21 Dec 2022 13:57:57 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301770 Archived-At: > +(when (and org-persist--disable-when-emacs-Q > + ;; FIXME: This is relying on undocumented fact that > + ;; Emacs sets `user-init-file' to nil when loaded with > + ;; "-Q" argument. > + (not user-init-file)) > + (setq org-persist-directory > + (make-temp-file "org-persist-" 'dir)) > + ;; We don't need the temp directory to exist. > + ;; `org-persist-write-all' will refrain from creating and writing to the dir if > + ;; none exists yet. > + (delete-directory org-persist-directory)) Could we skip the "create dir" so we can skip the `delete-directory` part as well? Also, this smells like a security hole: after `delete-directory`, with the /tmp setup as mode #o1777, some other user can come and create a directory at that location, so that our `org-persist-directory` will then point to their directory (where they may be able to read the things we write) or they can replace it with a link to a directory of our own tricking us into overwriting some of our own files. IOW, I suggest we use something like (setq org-persist-directory "/non-existing") or (setq org-persist-directory (make-temp-name "/non-existing")) [ Not sure if there is a standard such name that's "guaranteed" not to exist. ] Stefan