Re: emacs-29 02e046566e 3/3: Set beginning/end-of-defun-function in treesit-major-mode-setup

Re: emacs-29 02e046566e 3/3: Set beginning/end-of-defun-function in treesit-major-mode-setup

[Stefan Monnier]

> +    ;; `end-of-defun' will not work completely correctly in nested
> +    ;; defuns due to its implementation.  However, many lisp programs
> +    ;; use `beginning/end-of-defun', so we should still set
> +    ;; `beginning/end-of-defun-function' so they still mostly work.
> +    ;; This is also what `cc-mode' does: rebind user commands and set
> +    ;; the variables.  In future we should update `end-of-defun' to
> +    ;; work with nested defuns.
> +    (setq-local beginning-of-defun-function #'treesit-beginning-of-defun)
> +    (setq-local end-of-defun-function #'treesit-end-of-defun)))

Is there a bug report for that?


        Stefan

Re: emacs-29 02e046566e 3/3: Set beginning/end-of-defun-function in treesit-major-mode-setup

[Theodor Thornhill]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +    ;; `end-of-defun' will not work completely correctly in nested
>> +    ;; defuns due to its implementation.  However, many lisp programs
>> +    ;; use `beginning/end-of-defun', so we should still set
>> +    ;; `beginning/end-of-defun-function' so they still mostly work.
>> +    ;; This is also what `cc-mode' does: rebind user commands and set
>> +    ;; the variables.  In future we should update `end-of-defun' to
>> +    ;; work with nested defuns.
>> +    (setq-local beginning-of-defun-function #'treesit-beginning-of-defun)
>> +    (setq-local end-of-defun-function #'treesit-end-of-defun)))
>
> Is there a bug report for that?
>
>
>         Stefan


bug#60197

Theo