From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers Date: Tue, 21 Mar 2023 13:59:50 -0400 Message-ID: References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62300@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 21 19:01:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pegIU-0002on-6p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Mar 2023 19:01:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pegIF-0001wP-78; Tue, 21 Mar 2023 14:01:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pegIA-0001tz-Ny for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 14:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pegIA-0001jO-DY for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 14:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pegIA-0001ZH-83 for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 14:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Mar 2023 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62300 X-GNU-PR-Package: emacs Original-Received: via spool by 62300-submit@debbugs.gnu.org id=B62300.16794216065876 (code B ref 62300); Tue, 21 Mar 2023 18:01:02 +0000 Original-Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 18:00:06 +0000 Original-Received: from localhost ([127.0.0.1]:60494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegHG-0001Wi-JO for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:00:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegHF-0001Vf-OI for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 14:00:06 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 532AD808F9; Tue, 21 Mar 2023 14:00:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C5624805D4; Tue, 21 Mar 2023 13:59:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679421598; bh=OQCGhM5pEzJEjq13FZ1Rgu1M2gwLQgCutc8HwVPxan8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BZuBFCJPQCqK3IJkWw6uE1GMpJfwRk2X9PnByiL/QXsx7XSJFdt11Iywna2TlcMei 2FIB1I8ryKt/CX2Zf4cOZk5sG8swYIPFmXgKJyl3QW/Kvif8VLNhRGnE8e2CTvFg04 F9tkwEeyjisNKpCV7Uv7u99hJ0ZGW2EqR/nbZKQFjc/4CfBsrGiEP31Wsz3GxWuAzJ l0Ko8wpWfdHHTFobb5zipyna27VV98O7l1tqPGUxy4n4phlvWgs+Nej7IZWqVR9hbI SLLXOz6/m4bZIcBbHARVhkWZ0ZmIOHvr0py1Ay/U50Ds7cYUBQP8p9fXKZnq7/Quj/ DFRF4G4H25qDQ== Original-Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6292D123254; Tue, 21 Mar 2023 13:59:58 -0400 (EDT) In-Reply-To: <83a6066mnu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Mar 2023 19:26:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258359 Archived-At: > The latter means a regression, since symbols mentioned in the doc > string of text-scale-adjust will not be buttonized, like symbols in > the doc string of global-text-scale-adjust aren't now. I'd like to > find a solution that would cause symbols in both doc strings to be > buttonized (autoloading the defcustom does). The difference between the two use cases is largely accidental (due to details of how the definition-prefixes functionality works). I don't think tweaking the definition-prefixes would be wise way to solve this problem. (describe-function 'text-scale-adjust) suffers from the same "problem". We have not treated this as a problem until now, but if we want to treat it as a problem, then I suggest we do it by refining the way `help-enable-autoload` works. E.g. with the patch below. Stefan diff --git a/lisp/help-fns.el b/lisp/help-fns.el index a81051cee03..083acc5c98c 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1138,7 +1138,7 @@ describe-function-1 ;; key substitution constructs, load the library. (and (autoloadp real-def) doc-raw help-enable-autoload - (string-match "\\([^\\]=\\|[^=]\\|\\`\\)\\\\[[{<]" doc-raw) + (string-match "\\([^\\]=\\|[^=]\\|\\`\\)\\\\[[{<]\\|`.*'" doc-raw) (autoload-do-load real-def)) (help-fns--key-bindings function)