all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62300@debbugs.gnu.org
Subject: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers
Date: Tue, 21 Mar 2023 13:59:50 -0400	[thread overview]
Message-ID: <jwv355yf0t4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83a6066mnu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Mar 2023 19:26:29 +0200")

> The latter means a regression, since symbols mentioned in the doc
> string of text-scale-adjust will not be buttonized, like symbols in
> the doc string of global-text-scale-adjust aren't now.  I'd like to
> find a solution that would cause symbols in both doc strings to be
> buttonized (autoloading the defcustom does).

The difference between the two use cases is largely accidental (due to
details of how the definition-prefixes functionality works).  I don't
think tweaking the definition-prefixes would be wise way to solve
this problem.

(describe-function 'text-scale-adjust) suffers from the same "problem".
We have not treated this as a problem until now, but if we want to treat
it as a problem, then I suggest we do it by refining the way
`help-enable-autoload` works.

E.g. with the patch below.


        Stefan


diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index a81051cee03..083acc5c98c 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -1138,7 +1138,7 @@ describe-function-1
     ;; key substitution constructs, load the library.
     (and (autoloadp real-def) doc-raw
          help-enable-autoload
-         (string-match "\\([^\\]=\\|[^=]\\|\\`\\)\\\\[[{<]" doc-raw)
+         (string-match "\\([^\\]=\\|[^=]\\|\\`\\)\\\\[[{<]\\|`.*'" doc-raw)
          (autoload-do-load real-def))
 
     (help-fns--key-bindings function)






  reply	other threads:[~2023-03-21 17:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 18:34 bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers Eli Zaretskii
2023-03-20 18:52 ` Eli Zaretskii
2023-03-20 21:55   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-21 13:11     ` Eli Zaretskii
2023-03-21 14:19       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-21 17:26         ` Eli Zaretskii
2023-03-21 17:59           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-03-21 18:23             ` Eli Zaretskii
2023-03-21 19:09               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-21 19:54                 ` Eli Zaretskii
2023-03-22  1:48                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-22 15:52                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv355yf0t4.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=62300@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.