From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding refactoring capabilities to Emacs Date: Thu, 07 Sep 2023 13:06:56 -0400 Message-ID: References: <83fs4f36wi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , "Philip K." , Dmitry Gutov , emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 07 19:08:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeIUH-0001nX-F2 for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Sep 2023 19:08:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeITB-0002b1-Qv; Thu, 07 Sep 2023 13:07:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeITA-0002aj-Bm for emacs-devel@gnu.org; Thu, 07 Sep 2023 13:07:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeIT7-0002zr-BC; Thu, 07 Sep 2023 13:07:04 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 214354447C0; Thu, 7 Sep 2023 13:06:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694106417; bh=RoYwc1zGWvww5Utz1JiwnrDNAehmUe82TWDEJWh6EAo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LUXz6sIlltyfZFs571MlRb8gNHRAkgf1sMwpnQRQCUaelUSSYAc5aSjTi4qrjf0vt 0BN5Y7Nj9wAczTS0kny1bNJnOBU39S8w5Mzg10xcHNbz82xCS6tm5CRTE3PWveHMJA p/d/3HBKhAhpgAaJhwQRZxM0sZ3yYxhKQCixyXUuXHg18Y/BkpPw5U40YEj13izIz4 QSlrm8KtfHGiTJ8RVOUHvOG4B60qgNPiugxVdHc5yU+BpTxbXAqsjFnbmct+ygGBet uO6rU/31Uqdch1LbgYiTPpqGVNps16cgblED3xqDWj78MmkHRR7Rn6czo4voahWOGl ZMqljZtdIcl0A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 944BB44247C; Thu, 7 Sep 2023 13:06:57 -0400 (EDT) Original-Received: from pastel (69-165-136-223.dsl.teksavvy.com [69.165.136.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5E285120058; Thu, 7 Sep 2023 13:06:57 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Thu, 7 Sep 2023 17:49:25 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310269 Archived-At: >> Going back from there to the actual source code can be a fair bit more >> tricky, > Exactly. >> but Alan's symbols-with-positions should provide just what we need. > Great! but how? > Some years ago I presented a full source-tracking reader for Common Lisp > with just Lisp to a conference ;-) Needs a programmable reader though :-( > As you may remember, I then paired it with a full code walker to create > a stepper. We do have a "full source-tracking reader" writen in ELisp inside `edebug.el`. It's not 100% faithful to `lread.c`, but it seems to work well enough that we haven't heard too many bug reports about it over the years. Still, can't be used with `cconv` because the the "sexp with source-tracking info" don't have the shape expected by macros. > Is lread.c used for symbols-with-positions, or is code read in some > other completely new way? Yes, the symbols-with-positions thingy was done by extending `lread.c`. It keeps track of the source position only for symbols rather than for all Lisp objects, but it does it in a way which can survive macro-expansion. It's what's used in the byte-compiler to provide position info in the warnings. > Of course, but I don't understand the "tho", Yeah, it was probably not a correct usage. Please ignore it. > since that's exactly what I described. Yes, we agree. Stefan