From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Excessive use of `eassert` Date: Fri, 19 Jan 2024 12:44:26 -0500 Message-ID: References: <83jzo5x0q8.fsf@gnu.org> <83sf2tv029.fsf@gnu.org> <83mst1uwb9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15765"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eggert@cs.ucla.edu, acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 19 18:45:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQsvv-0003tq-PI for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Jan 2024 18:45:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQsv3-0000mX-2F; Fri, 19 Jan 2024 12:44:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQsuz-0000lx-KJ for emacs-devel@gnu.org; Fri, 19 Jan 2024 12:44:37 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQsuy-0007wA-0C; Fri, 19 Jan 2024 12:44:37 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B5FC31000DA; Fri, 19 Jan 2024 12:44:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1705686268; bh=P4mKwfVO77rQT76J6o5aYN2mmiIbx05BYjJvFqU9J+U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CeWo9WAMj3X06LempsGxsUX/Wpn53XKcwkaOZflLgyZq6HpQp19zuE5Ef9CWHIvGl X16ryuQh1QTnK5u/xdjqm5MwdtTyGfMcG/HiJ7JVV5pAd52OodMRzeQj0XWhyR1rIh VBuhFVhuxpxqKc+yW+iNMp4PKqUWhJNDoRRfqI/oNWqNTSLBZiYEDsywbuAV///z07 hCpsbNLRmCIgjVQuEGWq5cm0HYMsiixQG9HvvI/ms2hQOoT9ly2Z0T9GiwK5SnNCGy mtQd3hYvJVsCi8pOyLTSEa/aWiUeUf2JXZM132rWTGfV1jvtH/iZH6VUAJS3yPZ6bz JeEJKy1eAbT3g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 549DA10004C; Fri, 19 Jan 2024 12:44:28 -0500 (EST) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 26545120749; Fri, 19 Jan 2024 12:44:28 -0500 (EST) In-Reply-To: <83mst1uwb9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 Jan 2024 18:23:06 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315118 Archived-At: >> Same here. I can't vouch for 3.5 specifically, but 3-4 sounds about >> right for me as well. Tho I'll also note that (many) years ago >> the slowdown was lower, more in the 2x ballpark. > It's possible that GCC optimizes better nowadays. Also, back then we > had macros, not inline functions that sometimes aren't inlined. IIRC that ~2x factor was back when we used macros rather than inline static functions in .h files, indeed. The code has changed significantly since. Stefan