all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* compilation-mode makes the buffer read-only
@ 2004-10-31 23:05 Stefan
  2004-11-01  8:01 ` Daniel Pfeiffer
  2004-11-02  8:53 ` Richard Stallman
  0 siblings, 2 replies; 9+ messages in thread
From: Stefan @ 2004-10-31 23:05 UTC (permalink / raw)
  Cc: emacs-devel


The recent change that makes compilation-mode buffers read-only breaks
C-u M-x checkdoc-current-buffer RET

Of course I can add some inhibit-read-only bindings in checkdoc.el but why
not avoid those incompatibilities altogether.  How about the patch below?


        Stefan


--- orig/lisp/progmodes/compile.el
+++ mod/lisp/progmodes/compile.el
@@ -939,7 +939,9 @@
 	      (unless (getenv "EMACS") '("EMACS=t"))
 	      (copy-sequence process-environment))))
 	(if (not (eq mode t))
-	    (funcall mode)
+	    (progn
+	      (funcall mode)
+	      (setq buffer-read-only t))
 	  (setq buffer-read-only nil)
 	  (with-no-warnings (comint-mode))
 	  (compilation-shell-minor-mode))
@@ -1203,8 +1205,6 @@
   "Prepare the buffer for the compilation parsing commands to work.
 Optional argument MINOR indicates this is called from
 `compilation-minor-mode'."
-  (unless minor
-    (setq buffer-read-only t))
   (make-local-variable 'compilation-current-error)
   (make-local-variable 'compilation-messages-start)
   (make-local-variable 'compilation-error-screen-columns)

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2004-11-09 11:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-31 23:05 compilation-mode makes the buffer read-only Stefan
2004-11-01  8:01 ` Daniel Pfeiffer
2004-11-02  8:53 ` Richard Stallman
2004-11-02 12:11   ` Stefan
2004-11-03 12:45     ` Richard Stallman
2004-11-03 14:16       ` Stefan Monnier
2004-11-04  9:51         ` Richard Stallman
2004-11-05  8:05           ` Stefan
2004-11-09 11:14             ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.