all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* vc-find-root does not work for non-existent file argument
@ 2007-07-16  0:50 Dan Nicolaescu
  2007-07-19 18:51 ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2007-07-16  0:50 UTC (permalink / raw)
  To: emacs-devel



If FILE that is managed using either hg or bzr (both of which use
vc-find-root) is deleted, doing C-x C-f FILE RET after that will not
result emacs asking the question: "File FILE was lost; check out from version control? "

The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks
that FILE is not under version control. 
vc-find-root returns nil because of the way the result of
file-attributes is used...

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-find-root does not work for non-existent file argument
  2007-07-16  0:50 vc-find-root does not work for non-existent file argument Dan Nicolaescu
@ 2007-07-19 18:51 ` Stefan Monnier
  2007-07-20 17:56   ` Dan Nicolaescu
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2007-07-19 18:51 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

> If FILE that is managed using either hg or bzr (both of which use
> vc-find-root) is deleted, doing C-x C-f FILE RET after that will not
> result emacs asking the question: "File FILE was lost; check out from
> version control? "

> The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks
> that FILE is not under version control. 
> vc-find-root returns nil because of the way the result of
> file-attributes is used...

I believe this is fixed now, but there seem to be a related problem left
over, ... working on it,


        Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-find-root does not work for non-existent file argument
  2007-07-19 18:51 ` Stefan Monnier
@ 2007-07-20 17:56   ` Dan Nicolaescu
  2007-07-20 18:09     ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2007-07-20 17:56 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > > If FILE that is managed using either hg or bzr (both of which use
  > > vc-find-root) is deleted, doing C-x C-f FILE RET after that will not
  > > result emacs asking the question: "File FILE was lost; check out from
  > > version control? "
  > 
  > > The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks
  > > that FILE is not under version control. 
  > > vc-find-root returns nil because of the way the result of
  > > file-attributes is used...
  > 
  > I believe this is fixed now, but there seem to be a related problem left
  > over, ... working on it,

Is the issue you are still looking at something like this: 

mkdir -p /tmp/foo/bar

(vc-find-root "/tmp/foo/" "bar") => nil (instead of t)? 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-find-root does not work for non-existent file argument
  2007-07-20 17:56   ` Dan Nicolaescu
@ 2007-07-20 18:09     ` Stefan Monnier
  2007-07-21 16:59       ` Dan Nicolaescu
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2007-07-20 18:09 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

>> > If FILE that is managed using either hg or bzr (both of which use
>> > vc-find-root) is deleted, doing C-x C-f FILE RET after that will not
>> > result emacs asking the question: "File FILE was lost; check out from
>> > version control? "
>> 
>> > The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks
>> > that FILE is not under version control. 
>> > vc-find-root returns nil because of the way the result of
>> > file-attributes is used...
>> 
>> I believe this is fixed now, but there seem to be a related problem left
>> over, ... working on it,

> Is the issue you are still looking at something like this: 

> mkdir -p /tmp/foo/bar

> (vc-find-root "/tmp/foo/" "bar") => nil (instead of t)? 

Yes, and I believe it is fixed now,


        Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-find-root does not work for non-existent file argument
  2007-07-20 18:09     ` Stefan Monnier
@ 2007-07-21 16:59       ` Dan Nicolaescu
  2007-07-23  5:38         ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2007-07-21 16:59 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> > If FILE that is managed using either hg or bzr (both of which use
  > >> > vc-find-root) is deleted, doing C-x C-f FILE RET after that will not
  > >> > result emacs asking the question: "File FILE was lost; check out from
  > >> > version control? "
  > >> 
  > >> > The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks
  > >> > that FILE is not under version control. 
  > >> > vc-find-root returns nil because of the way the result of
  > >> > file-attributes is used...
  > >> 
  > >> I believe this is fixed now, but there seem to be a related problem left
  > >> over, ... working on it,
  > 
  > > Is the issue you are still looking at something like this: 
  > 
  > > mkdir -p /tmp/foo/bar
  > 
  > > (vc-find-root "/tmp/foo/" "bar") => nil (instead of t)? 
  > 
  > Yes, and I believe it is fixed now,

Can you please fix it on the 22.2 branch too? 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vc-find-root does not work for non-existent file argument
  2007-07-21 16:59       ` Dan Nicolaescu
@ 2007-07-23  5:38         ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2007-07-23  5:38 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

>> >> > If FILE that is managed using either hg or bzr (both of which use
>> >> > vc-find-root) is deleted, doing C-x C-f FILE RET after that will not
>> >> > result emacs asking the question: "File FILE was lost; check out from
>> >> > version control? "
>> >> 
>> >> > The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks
>> >> > that FILE is not under version control. 
>> >> > vc-find-root returns nil because of the way the result of
>> >> > file-attributes is used...
>> >> 
>> >> I believe this is fixed now, but there seem to be a related problem left
>> >> over, ... working on it,
>> 
>> > Is the issue you are still looking at something like this: 
>> 
>> > mkdir -p /tmp/foo/bar
>> 
>> > (vc-find-root "/tmp/foo/" "bar") => nil (instead of t)? 
>> 
>> Yes, and I believe it is fixed now,

> Can you please fix it on the 22.2 branch too? 

Done,


        Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-07-23  5:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-16  0:50 vc-find-root does not work for non-existent file argument Dan Nicolaescu
2007-07-19 18:51 ` Stefan Monnier
2007-07-20 17:56   ` Dan Nicolaescu
2007-07-20 18:09     ` Stefan Monnier
2007-07-21 16:59       ` Dan Nicolaescu
2007-07-23  5:38         ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.