From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Faces applies to new frames
Date: Sun, 29 Jun 2008 16:00:33 -0400 [thread overview]
Message-ID: <jwv1w2gc8rh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k5g8t56r.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 29 Jun 2008 15:24:44 -0400")
>> Yes, it makes a bit more sense, except that now I wonder why this
>> code would be needed at all? Isn't the `font' frame-parameter
>> automatically always kept up-to-date with the font of the
>> `default' face? If not, I think it should, and hence it should be done
>> elsewhere so that it's also true when we later change the default face
>> via `set-face-attributes' or something like that.
> This is because internal-merge-in-global-face (which is called in the
> middle of face-set-after-frame-default) merges in the face vector from
> face-new-frame-defaults without updating the `font' frame parameter.
> Every other place that changes the font uses set-face-attribute, which
> updates the `font' parameter correctly.
> I suppose we could change internal-merge-in-global-face to update the
> frame parameters itself, instead of adding a separate line in faces.el
> to do it.
Yes, that would make a lot more sense, wouldn't it?
[ Tho, I'd have expected that updating the `font' frame-parameter was
done at a lower-level, in a single place. ]
Stefan
next prev parent reply other threads:[~2008-06-29 20:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 22:50 Faces applies to new frames Chong Yidong
2008-06-26 23:08 ` Miles Bader
2008-06-27 1:28 ` Stefan Monnier
2008-06-27 2:43 ` Chong Yidong
2008-06-27 6:18 ` Stefan Monnier
2008-06-27 17:32 ` Chong Yidong
2008-06-27 17:52 ` Stefan Monnier
2008-06-27 17:54 ` Chong Yidong
2008-06-27 10:48 ` Robert J. Chassell
2008-06-27 12:17 ` Robert J. Chassell
2008-06-28 16:01 ` Chong Yidong
2008-06-28 20:17 ` Stefan Monnier
2008-06-28 23:42 ` Chong Yidong
2008-06-29 3:14 ` Stefan Monnier
2008-06-29 3:42 ` Miles Bader
2008-06-29 4:22 ` Stefan Monnier
2008-06-29 4:43 ` Miles Bader
2008-06-29 4:47 ` Chong Yidong
2008-06-29 8:51 ` David Kastrup
2008-06-29 5:36 ` Stefan Monnier
2008-06-29 15:20 ` Richard M Stallman
2008-06-29 17:08 ` Chong Yidong
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 19:42 ` Stefan Monnier
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 4:30 ` Chong Yidong
2008-06-29 6:11 ` Stefan Monnier
2008-06-29 15:25 ` Chong Yidong
2008-06-29 18:00 ` Stefan Monnier
2008-06-29 19:24 ` Chong Yidong
2008-06-29 20:00 ` Stefan Monnier [this message]
2008-06-29 20:29 ` Chong Yidong
2008-06-30 0:58 ` Stefan Monnier
2008-06-30 2:24 ` Chong Yidong
2008-06-30 4:46 ` Stefan Monnier
2008-06-30 5:02 ` Chong Yidong
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 2:48 ` Chong Yidong
2008-06-29 3:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1w2gc8rh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.