From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#810: 23.0.60; atomic-change-group narrowing problem Date: Mon, 01 Sep 2008 16:43:59 -0400 Message-ID: References: <48B6F562.9060006@gmail.com> <48BC2CE6.2070108@gmx.at> Reply-To: Stefan Monnier , 810@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1220303269 15452 80.91.229.12 (1 Sep 2008 21:07:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Sep 2008 21:07:49 +0000 (UTC) Cc: 810@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 01 23:08:43 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KaGda-0002Jb-Oc for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Sep 2008 23:08:39 +0200 Original-Received: from localhost ([127.0.0.1]:47653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaGcb-0006kk-Rl for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Sep 2008 17:07:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaGcZ-0006kQ-04 for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:07:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaGcX-0006jU-81 for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:07:34 -0400 Original-Received: from [199.232.76.173] (port=42344 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaGcX-0006jR-0q for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:07:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50445) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaGcW-0004Rw-Hr for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:07:32 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81L7UX1015660; Mon, 1 Sep 2008 14:07:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m81Ko3Zc008681; Mon, 1 Sep 2008 13:50:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 20:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 810 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 810-submit@emacsbugs.donarmstrong.com id=B810.12203018496875 (code B ref 810); Mon, 01 Sep 2008 20:50:03 +0000 Original-Received: (at 810) by emacsbugs.donarmstrong.com; 1 Sep 2008 20:44:09 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81Ki6Do006788 for <810@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 13:44:08 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMFACzxu0hFxJrH/2dsb2JhbACBZbEtgWmBBw X-IronPort-AV: E=Sophos;i="4.32,309,1217822400"; d="scan'208";a="26195606" Original-Received: from 69-196-154-199.dsl.teksavvy.com (HELO ceviche.home) ([69.196.154.199]) by ironport2-out.teksavvy.com with ESMTP; 01 Sep 2008 16:44:01 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 88DB0B41E3; Mon, 1 Sep 2008 16:43:59 -0400 (EDT) In-Reply-To: <48BC2CE6.2070108@gmx.at> (martin rudalics's message of "Mon, 01 Sep 2008 19:56:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Mon, 01 Sep 2008 17:07:34 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19985 Archived-At: >> When using atomic-change-group I got the message >> undo-more: Changes to be undone are outside visible portion of buffer >> The changes are also not undone. This seems wrong to me. > The attached patch now also tries to restore any narrowing in force > before the atomic change. I'm not sure we should do that. Currently, narrowing operations are not saved to the undo-log, so making atomic-change-group save&restore the narrowing makes it behave differently from the undo. Stefan