From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: How are VC switches supposed to work? Date: Tue, 02 Dec 2008 10:29:14 -0500 Message-ID: References: <50abbff1m0.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228231783 5743 80.91.229.12 (2 Dec 2008 15:29:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Dec 2008 15:29:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 02 16:30:46 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7XCw-000365-4Z for ged-emacs-devel@m.gmane.org; Tue, 02 Dec 2008 16:30:38 +0100 Original-Received: from localhost ([127.0.0.1]:43599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7XBl-0000R1-QT for ged-emacs-devel@m.gmane.org; Tue, 02 Dec 2008 10:29:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7XBh-0000Qg-Rf for emacs-devel@gnu.org; Tue, 02 Dec 2008 10:29:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7XBg-0000QR-9Z for emacs-devel@gnu.org; Tue, 02 Dec 2008 10:29:20 -0500 Original-Received: from [199.232.76.173] (port=51434 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7XBg-0000QO-6s for emacs-devel@gnu.org; Tue, 02 Dec 2008 10:29:20 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:12627 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L7XBe-00042B-Js; Tue, 02 Dec 2008 10:29:18 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAJLiNEnO+Jkl/2dsb2JhbACBbdEugn+BIw X-IronPort-AV: E=Sophos;i="4.33,702,1220241600"; d="scan'208";a="30539576" Original-Received: from 206-248-153-37.dsl.teksavvy.com (HELO pastel.home) ([206.248.153.37]) by ironport2-out.teksavvy.com with ESMTP; 02 Dec 2008 10:29:16 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id AE6D08BAF; Tue, 2 Dec 2008 10:29:14 -0500 (EST) In-Reply-To: <50abbff1m0.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 02 Dec 2008 03:00:23 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106430 Archived-At: > VC switches don't work as they are documented to work. > If someone can confirm that they work correctly, I will try to update > the many incorrect pieces of documentation. If on the other hand the > documentation is correct then the code needs fixing. > The documentation says that switches are appended. For example: > C-h v vc-diff-switches > C-h f vc-cvs-register > The Emacs manual "Examining And Comparing Old Revisions" > all say that it works, eg, as: vc-cvs-diff-switches + > vc-diff-switches + diff-switches. > In practice, (almost) everywhere uses the vc-switches function to > process switches. This does no appending, it simply returns the first > non-nil element. > For example: > (setq vc-cvs-diff-switches "-a" > vc-diff-switches "-b" > diff-switches "-c") > (vc-switches 'CVS 'diff) > -> '("-a") > The situation was basically the same (ie inconsistent) in Emacs 22 AFAICS. I can't remember all the details, but I do remember that appending is not good enough because you may have switches in diff-switches that are not accepted by some backends. Stefan