From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase Date: Sun, 17 May 2009 17:40:05 -0400 Message-ID: References: <19e566510808190319r454900a7sc3b5a4e9d6d68f95@mail.gmail.com> <19e566510808200117y21e78086la6240ad72b676cd7@mail.gmail.com> <19e566510808211140n56bec8e7l7ac7d6ae156e29eb@mail.gmail.com> <87k5eataqu.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242596427 15920 80.91.229.12 (17 May 2009 21:40:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 May 2009 21:40:27 +0000 (UTC) Cc: =?utf-8?Q?=C4=B0smail_D=C3=B6nm?=, Chong Yidong , emacs-devel@gnu.org, =?utf-8?Q?ez?= To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 17 23:40:20 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M5o5h-0000sh-PP for ged-emacs-devel@m.gmane.org; Sun, 17 May 2009 23:40:18 +0200 Original-Received: from localhost ([127.0.0.1]:35206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5o5h-0004ge-6i for ged-emacs-devel@m.gmane.org; Sun, 17 May 2009 17:40:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5o5b-0004gW-FL for emacs-devel@gnu.org; Sun, 17 May 2009 17:40:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5o5X-0004gB-BN for emacs-devel@gnu.org; Sun, 17 May 2009 17:40:11 -0400 Original-Received: from [199.232.76.173] (port=37348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5o5W-0004g8-R8 for emacs-devel@gnu.org; Sun, 17 May 2009 17:40:06 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:40152) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M5o5W-0003rT-C8 for emacs-devel@gnu.org; Sun, 17 May 2009 17:40:06 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvAFAIchEEpMCovv/2dsb2JhbACBT808hAEFhWqCOA X-IronPort-AV: E=Sophos;i="4.41,208,1241409600"; d="scan'208";a="38714132" Original-Received: from 76-10-139-239.dsl.teksavvy.com (HELO ceviche.home) ([76.10.139.239]) by ironport2-out.teksavvy.com with ESMTP; 17 May 2009 17:40:05 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 54D8770017; Sun, 17 May 2009 17:40:05 -0400 (EDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Wed, 13 May 2009 12:27:01 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110956 Archived-At: > I confirmed that the libX11 shipped with Mac OS X 10.4 doesn't contain > the above change. > http://www.opensource.apple.com/source/X11/X11-0.46.4/xc/lib/X11/ > If we remove the XrmDestroyDatabase call unconditionally, then it > causes a memory leak when used with a newer libX11. But that would be > better than crashing when used with an older one. OTOH, it's better to work correctly with the new code than with the old code (better be future-proof than past-proof). Seeing how Mac OS X 10.5 has been out for a while now, I expect most users of Emacs-23 will run with code that would tend to leak rather than with code that would tend to crash. So, I'd rather just free XrmDestroyDatabase and add a note in PROBLEMS that with older releases of libX11 there may be crashes when closing the display. Stefan