From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: PATCH: Fix IDO interaction with uniquify.el Date: Wed, 05 May 2010 14:14:17 -0400 Message-ID: References: <87k4vf1zdh.fsf@telefonica.net> <87d4171oy1.fsf@telefonica.net> <87636z1nm7.fsf@telefonica.net> <87d417h0z6.fsf@stupidchicken.com> <87tyujz57h.fsf@telefonica.net> <87ockrz4eu.fsf@telefonica.net> <87pr57uw25.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1273099409 10154 80.91.229.12 (5 May 2010 22:43:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 5 May 2010 22:43:29 +0000 (UTC) Cc: =?iso-8859-1?Q?=D3scar?= Fuentes , Chong Yidong , Leo , emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 06 00:43:27 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O9nJP-0000gP-1E for ged-emacs-devel@m.gmane.org; Thu, 06 May 2010 00:43:27 +0200 Original-Received: from localhost ([127.0.0.1]:42055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9nJN-00042A-EO for ged-emacs-devel@m.gmane.org; Wed, 05 May 2010 18:43:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9jzJ-0004gT-3U for emacs-devel@gnu.org; Wed, 05 May 2010 15:10:29 -0400 Original-Received: from [140.186.70.92] (port=53269 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9j7B-0006ND-QI for emacs-devel@gnu.org; Wed, 05 May 2010 14:14:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9j6w-00013y-N1 for emacs-devel@gnu.org; Wed, 05 May 2010 14:14:33 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:18669 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9j6w-00013s-I9 for emacs-devel@gnu.org; Wed, 05 May 2010 14:14:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEABBS4UvO+IB1/2dsb2JhbACdTHK9DIUTBIws X-IronPort-AV: E=Sophos;i="4.52,335,1270440000"; d="scan'208";a="63484125" Original-Received: from 206-248-128-117.dsl.teksavvy.com (HELO pastel.home) ([206.248.128.117]) by ironport2-out.pppoe.ca with ESMTP; 05 May 2010 14:14:17 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 935E2814C; Wed, 5 May 2010 14:14:17 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Wed, 5 May 2010 11:56:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124561 Archived-At: >> I confirm the original bug report. I propose here a different fix for >> both ido and iswitch. It is much simpler and more efficient. > On the minus side, your patch: > - is less generic; =D3scar's will work for other packages that do > dynamic renaming of buffers (yes, there are none on the Emacs > distribution, but there's a lot of elisp code out there). > - makes ido depend on a feature of uniquify, which it didn't before. Even more problematic: it changes the behavior of uniquify. Can someone install Oscar's patch? BTW, I don't understand why his patch changes (defvar ido-cur-list) and (defvar ido-choice-list) into (defvar ido-cur-list nil) and (defvar ido-choice-list nil). These changes aren't necessarily bad, but I suspect the change is either unneeded or hiding a bug. Stefan