From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: "Óscar Fuentes" <ofv@wanadoo.es>,
"Chong Yidong" <cyd@stupidchicken.com>, Leo <sdl.web@gmail.com>,
emacs-devel@gnu.org
Subject: Re: PATCH: Fix IDO interaction with uniquify.el
Date: Wed, 05 May 2010 14:14:17 -0400 [thread overview]
Message-ID: <jwv1vdqp69d.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <y2mf7ccd24b1005050256s84f4920fr405155ab5a1dc345@mail.gmail.com> (Juanma Barranquero's message of "Wed, 5 May 2010 11:56:50 +0200")
>> I confirm the original bug report. I propose here a different fix for
>> both ido and iswitch. It is much simpler and more efficient.
> On the minus side, your patch:
> - is less generic; Óscar's will work for other packages that do
> dynamic renaming of buffers (yes, there are none on the Emacs
> distribution, but there's a lot of elisp code out there).
> - makes ido depend on a feature of uniquify, which it didn't before.
Even more problematic: it changes the behavior of uniquify.
Can someone install Oscar's patch?
BTW, I don't understand why his patch changes (defvar ido-cur-list)
and (defvar ido-choice-list) into (defvar ido-cur-list nil)
and (defvar ido-choice-list nil). These changes aren't necessarily bad,
but I suspect the change is either unneeded or hiding a bug.
Stefan
next prev parent reply other threads:[~2010-05-05 18:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 10:27 PATCH: Fix IDO interaction with uniquify.el Óscar Fuentes
2010-01-18 10:59 ` Juanma Barranquero
2010-01-18 11:12 ` Juanma Barranquero
2010-01-18 14:13 ` Óscar Fuentes
2010-01-18 14:32 ` Juanma Barranquero
2010-01-18 14:41 ` Óscar Fuentes
2010-01-18 15:44 ` Chong Yidong
2010-01-18 17:35 ` Óscar Fuentes
2010-01-18 17:52 ` Óscar Fuentes
2010-01-18 18:06 ` Chong Yidong
2010-01-18 19:17 ` Juanma Barranquero
2010-05-05 8:27 ` Leo
2010-05-05 9:56 ` Juanma Barranquero
2010-05-05 12:40 ` Leo
2010-05-05 16:47 ` Juanma Barranquero
2010-05-05 17:35 ` Leo
2010-05-05 19:12 ` Leo
2010-05-05 19:48 ` Juanma Barranquero
2010-05-06 12:54 ` Stefan Monnier
2010-05-05 17:56 ` Leo
2010-05-05 19:25 ` Juanma Barranquero
2010-05-05 18:14 ` Stefan Monnier [this message]
2010-05-05 19:09 ` Óscar Fuentes
2010-05-05 19:50 ` Leo
2010-05-05 19:59 ` Leo
2010-05-05 20:36 ` Óscar Fuentes
2010-05-06 20:43 ` Juri Linkov
2010-05-05 20:27 ` Stefan Monnier
2010-05-05 20:38 ` Óscar Fuentes
2010-05-06 16:56 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1vdqp69d.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=ofv@wanadoo.es \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.