From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5937: 23.1.95; why saving empty abbrev tables Date: Tue, 29 Mar 2011 09:49:15 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301410468 17570 80.91.229.12 (29 Mar 2011 14:54:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2011 14:54:28 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 29 16:54:24 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4aJK-0008QV-Ty for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2011 16:54:23 +0200 Original-Received: from localhost ([127.0.0.1]:59799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4aJJ-0007Bf-R5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2011 10:54:21 -0400 Original-Received: from [140.186.70.92] (port=42836 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4ZsK-0003Bu-LI for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2011 10:26:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4ZZe-0004rs-Kx for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2011 10:07:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4ZZe-0004ri-J9 for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2011 10:07:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q4ZK2-0007oU-0G; Tue, 29 Mar 2011 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Mar 2011 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5937 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.130140661429980 (code B ref -1); Tue, 29 Mar 2011 13:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Mar 2011 13:50:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4ZJG-0007nU-DM for submit@debbugs.gnu.org; Tue, 29 Mar 2011 09:50:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4ZJE-0007nJ-M1 for submit@debbugs.gnu.org; Tue, 29 Mar 2011 09:50:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4ZJ8-0001WE-4K for submit@debbugs.gnu.org; Tue, 29 Mar 2011 09:50:07 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:48672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4ZIv-0001P5-42 for submit@debbugs.gnu.org; Tue, 29 Mar 2011 09:50:06 -0400 Original-Received: from [140.186.70.92] (port=60899 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4ZIQ-0004oD-1G for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2011 09:49:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4ZIK-0001Nk-LV for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2011 09:49:17 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:52377 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4ZIK-0001NZ-Gj for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2011 09:49:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAIzikU1MCqRC/2dsb2JhbAClTHiIebwnhWoElhA X-IronPort-AV: E=Sophos;i="4.63,262,1299474000"; d="scan'208";a="98498903" Original-Received: from 76-10-164-66.dsl.teksavvy.com (HELO pastel.home) ([76.10.164.66]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 29 Mar 2011 09:49:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1B01358EBD; Tue, 29 Mar 2011 09:49:15 -0400 (EDT) In-Reply-To: (Leo's message of "Tue, 29 Mar 2011 13:16:23 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 29 Mar 2011 09:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45472 Archived-At: >> +(defun abbrev-save-buffer () >> + "Save all user-level abbrev definitions in current buffer. >> +The saved abbrevs are written to the file specified by >> +`abbrev-file-name'." >> + (interactive) >> + (and (derived-mode-p 'edit-abbrevs-mode) >> + (edit-abbrevs-redefine)) No need for the derived-mode-p check. But this reminds me: the name should include "edit" (e.g. abbrev-edit-save-buffer) to make it clear that it's about edit-abbrevs. >> +(defun abbrev-save-to-file (file) Same here. >> + "Save all user-level abbrev definitions in current buffer to FILE." >> + (interactive >> + (list (read-file-name "Save abbrevs to file: " >> + (file-name-directory >> + (expand-file-name abbrev-file-name)) >> + abbrev-file-name))) >> + (and (derived-mode-p 'edit-abbrevs-mode) >> + (edit-abbrevs-redefine)) >> + (write-abbrev-file file t)) > Should define abbrev-save-buffer as: > (defun abbrev-save-buffer () > "Save all user-level abbrev definitions in current buffer. > The saved abbrevs are written to the file specified by > `abbrev-file-name'." > (interactive) > (abbrev-save-to-file abbrev-file-name)) Yes, that sounds like a good idea. Stefan