bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Michael Heerdegen]

Hi,

in emacs -Q, open an elisp file and enable `view-mode'.

Now, instrument any defun in this buffer and eval something that
causes that function to be called.

You enter an edebug session, but nearly all edebug bindings won't work
because they trigger `view-mode' bindings in this buffer instead.


In GNU Emacs 24.0.94.1 (i486-pc-linux-gnu, GTK+ Version 3.2.3)
 of 2012-03-12 on zelenka, modified by Debian
 (emacs-snapshot package, version 2:20120312-1)
Windowing system distributor `The X.Org Foundation', version 11.0.11103901
Configured using:
 `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.0.94/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.0.94/site-lisp:/usr/share/emacs/site-lisp'
 '--without-compress-info' '--with-crt-dir=/usr/lib/i386-linux-gnu/'
 '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes'
 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu'
 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2''

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Andreas Schwab]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> You enter an edebug session, but nearly all edebug bindings won't work
> because they trigger `view-mode' bindings in this buffer instead.

Every edebug binding is also available under the C-x X prefix.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Michael Heerdegen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> > You enter an edebug session, but nearly all edebug bindings won't work
> > because they trigger `view-mode' bindings in this buffer instead.
>
> Every edebug binding is also available under the C-x X prefix.

Yes, that's `global-edebug-prefix'.  In the header, there is a typo,
here:

;; If you wish to change the default edebug global command prefix, change:
;; (setq edebug-global-prefix "\C-xX")
         -------------      

There is no binding for `edebug-next-mode' (i.e. n in `edebug-mode-map')
in `global-edebug-map' (why?).

I would have to type C-x X SPC C-x X SPC ... to step through the code -
a pain in the ass.

I don't have an elegant solution for this problem.  It is not a problem
especially with `view-mode'.  All minor mode bindings shadow
`edebug-mode-map' which is used as local map.

If there was an `edebug-mode-hook', then the user could deactivate
interfering minor modes there.


Michael.

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Stefan Monnier]

> I don't have an elegant solution for this problem.  It is not a problem
> especially with `view-mode'.  All minor mode bindings shadow
> `edebug-mode-map' which is used as local map.

Maybe it should be installed with higher precedence, by virtue of
being transient.

> If there was an `edebug-mode-hook', then the user could deactivate
> interfering minor modes there.

That could be an alternative, but then you'd probably want to re-enable
it when leaving edebug mode, which would enable&disable it very often
and could be difficult to implement efficiently.


        Stefan

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Stefan Monnier]

> That could be an alternative, but then you'd probably want to re-enable
> it when leaving edebug mode, which would enable&disable it very often
> and could be difficult to implement efficiently.
                                      ^^^^^^^^^^^
                                      reliably
Sorry, wasn't thinking right,


        Stefan

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I don't have an elegant solution for this problem.  It is not a problem
>> especially with `view-mode'.  All minor mode bindings shadow
>> `edebug-mode-map' which is used as local map.
>
> Maybe it should be installed with higher precedence, by virtue of
> being transient.

That sounds like a good idea.  How is the precedence of minor mode maps
determined?

Hm...  I see that minor-mode-overriding-map-alist exists -- should
edebug put its keymap there instead of minor-mode-map-alist?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Stefan Monnier]

>>> I don't have an elegant solution for this problem.  It is not a problem
>>> especially with `view-mode'.  All minor mode bindings shadow
>>> `edebug-mode-map' which is used as local map.
>>
>> Maybe it should be installed with higher precedence, by virtue of
>> being transient.
>
> That sounds like a good idea.  How is the precedence of minor mode maps
> determined?
>
> Hm...  I see that minor-mode-overriding-map-alist exists -- should
> edebug put its keymap there instead of minor-mode-map-alist?

That might work,


        Stefan

bug#15451: bug#11018: 24.0.94; Edebug: bindings shadowed by view-mode

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Hm...  I see that minor-mode-overriding-map-alist exists -- should
>> edebug put its keymap there instead of minor-mode-map-alist?
>
> That might work,

That seemed to work -- I bound it in edebug--recursive-edit, so it
shouldn't mess anything up after exiting edebug.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no