From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 14989@debbugs.gnu.org
Subject: bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits
Date: Tue, 30 Jul 2013 21:38:03 -0400 [thread overview]
Message-ID: <jwv1u6fv7c1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8738qv8ya6.fsf@axl.i-did-not-set--mail-host-address--so-tickle-me> (Dmitry Gutov's message of "Wed, 31 Jul 2013 01:42:57 +0300")
> This fix is simple enough. Apply?
Looks good, thanks.
> The functions could also use some further cleanup:
> 1) Swap the `to' and `fr' local variables.
I think that would make sense, yes.
> 2) Extract the function bodies to one function with a third argument
> (called `whole-changeset', maybe), and make them call it.
If that can be done without too much extra code, that sounds good.
Stefan
next prev parent reply other threads:[~2013-07-31 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 22:42 bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits Dmitry Gutov
2013-07-31 1:38 ` Stefan Monnier [this message]
2013-07-31 12:26 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1u6fv7c1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14989@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.