From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15122: 24.3.50; [PATCH] byte-compiler warnings about destructive functions Date: Tue, 20 Aug 2013 10:39:54 -0400 Message-ID: References: <9ee2e7bb-6036-4e81-bb44-86d4ac74e7b8@default> <189c1f04-03cf-4dbb-b8ac-b190a774788c@default> <788e435c-ad81-40b1-8f92-3a55d3da6cd9@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1377009623 12848 80.91.229.3 (20 Aug 2013 14:40:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Aug 2013 14:40:23 +0000 (UTC) Cc: 15122@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 20 16:40:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBn6d-0007Cm-TF for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2013 16:40:24 +0200 Original-Received: from localhost ([::1]:48267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBn6d-00067u-BV for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2013 10:40:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBn6T-00066P-4J for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2013 10:40:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBn6J-0001k8-To for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2013 10:40:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBn6J-0001jp-Qk for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2013 10:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VBn6I-00086l-Vc for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2013 10:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2013 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15122-submit@debbugs.gnu.org id=B15122.137700959931150 (code B ref 15122); Tue, 20 Aug 2013 14:40:02 +0000 Original-Received: (at 15122) by debbugs.gnu.org; 20 Aug 2013 14:39:59 +0000 Original-Received: from localhost ([127.0.0.1]:42693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VBn6E-00086J-Mo for submit@debbugs.gnu.org; Tue, 20 Aug 2013 10:39:59 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:57432) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VBn6C-00085m-2H for 15122@debbugs.gnu.org; Tue, 20 Aug 2013 10:39:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCzQSFBgNJIgeBrEfkA6NDoN8A6R6gV6DEw X-IPAS-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCzQSFBgNJIgeBrEfkA6NDoN8A6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="22610155" Original-Received: from 206-248-179-83.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.179.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Aug 2013 10:39:48 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 084F1AE1E2; Tue, 20 Aug 2013 10:39:55 -0400 (EDT) In-Reply-To: <788e435c-ad81-40b1-8f92-3a55d3da6cd9@default> (Drew Adams's message of "Tue, 20 Aug 2013 07:07:36 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77544 Archived-At: >> > might not be aware of when they might be doing so. I mentioned Scheme's >> > explicit choice to name all such functions in a noticeable way. Drawing >> > attention to (all) use of destructive operations is not necessarily a >> > useless thing, depending on the user and context. >> Yes, I like Scheme's convention. > Then consider adding (subtle, optional) font-lock highlighting of such. > That would anyway be better than compiler warnings. The list of fns > I came up with is a start. You might even consider putting a recognizable > property on the function symbols, as well. Font-lock might be a good idea, indeed. We could also additionally start to introduce Scheme-style names, like sort!, reverse!, butlast!, ... Stefan