From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17772: [PATCH] Dangling channels' buffer Date: Fri, 13 Jun 2014 14:36:16 -0400 Message-ID: References: <87k38lay6k.fsf@tanger.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402684648 19373 80.91.229.3 (13 Jun 2014 18:37:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Jun 2014 18:37:28 +0000 (UTC) Cc: Ryan Yeske , Leo Liu , 17772@debbugs.gnu.org To: Daimrod Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 13 20:37:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WvWLn-0003aV-M2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 20:37:19 +0200 Original-Received: from localhost ([::1]:60623 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvWLn-0008Lt-9A for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 14:37:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvWLd-0008KF-Ov for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:37:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvWLW-0005dL-9u for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:37:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvWLW-0005dF-6V for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WvWLV-00037t-Mo for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17772-submit@debbugs.gnu.org id=B17772.140268458511958 (code B ref 17772); Fri, 13 Jun 2014 18:37:01 +0000 Original-Received: (at 17772) by debbugs.gnu.org; 13 Jun 2014 18:36:25 +0000 Original-Received: from localhost ([127.0.0.1]:46928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvWKv-00036n-99 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 14:36:25 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:62576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvWKs-00036T-On for 17772@debbugs.gnu.org; Fri, 13 Jun 2014 14:36:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF4lMhS4HhDgEqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF4lMhS4HhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="66800387" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jun 2014 14:36:16 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B27FD660D3; Fri, 13 Jun 2014 14:36:16 -0400 (EDT) In-Reply-To: <87k38lay6k.fsf@tanger.home> (daimrod@gmail.com's message of "Fri, 13 Jun 2014 19:41:55 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90353 Archived-At: > server process when it existed, or nil. However, since a78d87e7ed it > raises an error. Please avoid using Git references until we actually switch to Git. Use dates, for example, instead. > This is a problem if the user kills the server buffer before it kills > the channels' buffer because it is not possible to kill them after that. > (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook' > and it calls `rcirc-buffer-process'.) Your patch doesn't look bad, but I wonder if a better option wouldn't be to try and better preserve the previous behavior. E.g. with the patch below. WDYT? Stefan === modified file 'lisp/net/rcirc.el' --- lisp/net/rcirc.el 2014-05-12 16:06:13 +0000 +++ lisp/net/rcirc.el 2014-06-13 18:34:01 +0000 @@ -803,9 +804,8 @@ "Return the process associated with channel BUFFER. With no argument or nil as argument, use the current buffer." (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer) - rcirc-server-buffer - (error "Server buffer deleted"))))) - (or (with-current-buffer buffer rcirc-process) + rcirc-server-buffer)))) + (or (if buffer (with-current-buffer buffer rcirc-process)) rcirc-process))) (defun rcirc-server-name (process)