From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18643: 25.0.50; elisp--expect-function-p Date: Thu, 09 Oct 2014 11:27:44 -0400 Message-ID: References: <86oatmq7lc.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1412868513 26489 80.91.229.3 (9 Oct 2014 15:28:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Oct 2014 15:28:33 +0000 (UTC) Cc: Dmitry Gutov , 18643@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 09 17:28:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XcFdf-0006Tf-2M for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Oct 2014 17:28:23 +0200 Original-Received: from localhost ([::1]:43158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcFde-0008En-LM for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Oct 2014 11:28:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcFdS-00084C-20 for bug-gnu-emacs@gnu.org; Thu, 09 Oct 2014 11:28:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcFdK-0003Qu-Gd for bug-gnu-emacs@gnu.org; Thu, 09 Oct 2014 11:28:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcFdK-0003QW-EL for bug-gnu-emacs@gnu.org; Thu, 09 Oct 2014 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XcFdJ-0002LL-UI for bug-gnu-emacs@gnu.org; Thu, 09 Oct 2014 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Oct 2014 15:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18643 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18643-submit@debbugs.gnu.org id=B18643.14128684718976 (code B ref 18643); Thu, 09 Oct 2014 15:28:01 +0000 Original-Received: (at 18643) by debbugs.gnu.org; 9 Oct 2014 15:27:51 +0000 Original-Received: from localhost ([127.0.0.1]:39292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcFd8-0002Kf-0T for submit@debbugs.gnu.org; Thu, 09 Oct 2014 11:27:50 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:4450) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcFd3-0002KR-Fx for 18643@debbugs.gnu.org; Thu, 09 Oct 2014 11:27:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="93698947" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Oct 2014 11:27:44 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5290785A3; Thu, 9 Oct 2014 11:27:44 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Thu, 09 Oct 2014 11:31:13 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94337 > It is the false negatives that kill its usefulness in the case of elisp. > For example, (ert-deftest |) and (defun |) no longer have the > completions I need. Dmitry, what is it exactly that changed? I mean, Elisp completion has been context-sensitive "for ever", so the change is not that it now is, but that it now reacts to the context differently. Oh, I think I see: the change is the introduction of elisp--form-quoted-p such that if elisp--form-quoted-p returns nil (and we're not expecting a function), we only complete against var names instead of the previous behavior of expanding against "anything". I think this is not right: we should have a elisp--expect-exp-p which returns non-nil in a context where we know the symbol at point should be a valid expression (i.e. a variable). Not sure how to write it, tho, but in its absence I think we're better off completing against "anything" than restricting ourselves to variables. BTW, to improve on these behaviors, one approach is to take the macro-expansion code used in elisp--local-variables and use it "everywhere". I.e. expand elisp--local-variables so it doesn't just return the list of local vars, but also returns whether we're inside a quote, or we're expecting a function, or we're expecting an expression. Stefan