* bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook)
@ 2015-05-18 14:26 Christoph Ruegge
[not found] ` <handler.20601.B.143195920232200.ack@debbugs.gnu.org>
2015-05-22 4:03 ` bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook) Stefan Monnier
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Ruegge @ 2015-05-18 14:26 UTC (permalink / raw)
To: 20601
Documentation of make-local-variable says that this should not be done,
and it causes problems with other code that wants to add to that hook.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#20601: Acknowledgement (25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook))
[not found] ` <handler.20601.B.143195920232200.ack@debbugs.gnu.org>
@ 2015-05-18 15:43 ` Christoph Ruegge
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Ruegge @ 2015-05-18 15:43 UTC (permalink / raw)
To: 20601
To expand this a bit, the following steps highlight a problem,
starting from emacs -Q:
1) Eval "(custom-set-variables '(global-auto-revert-mode t)
'(save-place-mode t nil (saveplace)))" in the *scratch* buffer. Now
kill-buffer-hook contains save-place-to-alist.
2) Open another file. Now save-place-alist is gone from the hook.
When changing autorevert.el to use add-hook's "local" parameter, the
problem does not occur.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook)
2015-05-18 14:26 bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook) Christoph Ruegge
[not found] ` <handler.20601.B.143195920232200.ack@debbugs.gnu.org>
@ 2015-05-22 4:03 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2015-05-22 4:03 UTC (permalink / raw)
To: Christoph Ruegge; +Cc: 20601-done
> Documentation of make-local-variable says that this should not be done,
Rightly so, yes.
> and it causes problems with other code that wants to add to that hook.
Indeed, thanks for spotting it! Should be fixed now in master.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-22 4:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 14:26 bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook) Christoph Ruegge
[not found] ` <handler.20601.B.143195920232200.ack@debbugs.gnu.org>
2015-05-18 15:43 ` bug#20601: Acknowledgement (25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook)) Christoph Ruegge
2015-05-22 4:03 ` bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook) Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.