From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master' Date: Sat, 13 Jun 2015 10:23:37 -0400 Message-ID: References: <20150612184810.23227.21127@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1434205734 1794 80.91.229.3 (13 Jun 2015 14:28:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Jun 2015 14:28:54 +0000 (UTC) Cc: Alexey Veretennikov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 13 16:28:36 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z3mQG-0001U2-Dx for ged-emacs-devel@m.gmane.org; Sat, 13 Jun 2015 16:28:36 +0200 Original-Received: from localhost ([::1]:56173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3mQF-0000Lk-LJ for ged-emacs-devel@m.gmane.org; Sat, 13 Jun 2015 10:28:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3mLY-000280-81 for emacs-devel@gnu.org; Sat, 13 Jun 2015 10:23:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3mLU-0005VH-Ic for emacs-devel@gnu.org; Sat, 13 Jun 2015 10:23:44 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:32935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3mLU-0005Ur-Eb for emacs-devel@gnu.org; Sat, 13 Jun 2015 10:23:40 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t5DENb9v015032; Sat, 13 Jun 2015 10:23:37 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 73FB0AE0CA; Sat, 13 Jun 2015 10:23:37 -0400 (EDT) In-Reply-To: (Alexey Veretennikov's message of "Fri, 12 Jun 2015 18:48:12 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5336=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5336> : inlines <3192> : streams <1454782> : uri <1957964> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187156 Archived-At: > -;; Compatibility: GNU Emacs GNU Emacs 24.x > +;; Compatibility: GNU Emacs 24.x So is it OK if I change those files to use lexical-binding? > (defun newline-and-begin () > "Move a point to the beginning of the next line." > - (newline) > + (insert "\n") > (beginning-of-line)) The beginning-of-line can be removed as well (at which point you're better off removing newline-and-begin altogether and simply replace every call by (insert "\n")). One more thing: I see that ztree-util.el defines several functions (such as the one here) without a "ztree-" prefix. It would be good to fix this. Stefan