From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/project 106e023: Add new `project' package, and use it in xref Date: Wed, 08 Jul 2015 10:06:57 -0400 Message-ID: References: <20150708000935.5340.18494@vcs.savannah.gnu.org> <559D21F0.2060607@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1436364457 24019 80.91.229.3 (8 Jul 2015 14:07:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jul 2015 14:07:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 08 16:07:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZCq0U-0003Ok-3B for ged-emacs-devel@m.gmane.org; Wed, 08 Jul 2015 16:07:26 +0200 Original-Received: from localhost ([::1]:35274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCq0T-0003vc-Fg for ged-emacs-devel@m.gmane.org; Wed, 08 Jul 2015 10:07:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCq05-0003tg-PC for emacs-devel@gnu.org; Wed, 08 Jul 2015 10:07:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCq02-00074m-Jz for emacs-devel@gnu.org; Wed, 08 Jul 2015 10:07:01 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCq02-00074S-GM for emacs-devel@gnu.org; Wed, 08 Jul 2015 10:06:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DaFgA731xV/2cGNJ1cgxCEAoVVwgOBCAQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYREgULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBZluBYUkg2uSAiOCO4FZIoJ4AQEB X-IPAS-Result: A0DaFgA731xV/2cGNJ1cgxCEAoVVwgOBCAQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYREgULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBZluBYUkg2uSAiOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="129521938" Original-Received: from 157-52-6-103.cpe.teksavvy.com (HELO pastel.home) ([157.52.6.103]) by ironport2-out.teksavvy.com with ESMTP; 08 Jul 2015 10:06:57 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A600660647; Wed, 8 Jul 2015 10:06:57 -0400 (EDT) In-Reply-To: <559D21F0.2060607@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Jul 2015 16:13:20 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187774 Archived-At: > Sounds good. Please take a look again. Good, thanks. >> Why use a cons cell with the car's symbol standing for a type tag, when >> the carried object is already properly self-describing (IIUC it's an >> EIEIO object)? > Because then dispatching any `project-root' call fails at runtime if ede is > not loaded. And I don't want to make it a runtime dependency. > This function should probably be in ede.el, and only added to > project-find-functions when it's loaded. Exactly: rather than work around the problem by using a cons cell, better do it by moving the function where it belongs. > Any comments on the "source directories" issue? I'm inclining towards > having a project-source-directories-function variable now, which in > emacs-lisp-mode would return load-path. I haven't had time to look into that yet, sorry. Stefan