all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/project 106e023: Add new `project' package, and use it in xref
Date: Wed, 08 Jul 2015 10:06:57 -0400	[thread overview]
Message-ID: <jwv1tgisq16.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <559D21F0.2060607@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Jul 2015 16:13:20 +0300")

> Sounds good. Please take a look again.

Good, thanks.

>> Why use a cons cell with the car's symbol standing for a type tag, when
>> the carried object is already properly self-describing (IIUC it's an
>> EIEIO object)?
> Because then dispatching any `project-root' call fails at runtime if ede is
> not loaded. And I don't want to make it a runtime dependency.
> This function should probably be in ede.el, and only added to
> project-find-functions when it's loaded.

Exactly: rather than work around the problem by using a cons cell,
better do it by moving the function where it belongs.

> Any comments on the "source directories" issue? I'm inclining towards
> having a project-source-directories-function variable now, which in
> emacs-lisp-mode would return load-path.

I haven't had time to look into that yet, sorry.


        Stefan



  reply	other threads:[~2015-07-08 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150708000935.5340.18494@vcs.savannah.gnu.org>
     [not found] ` <E1ZCcvg-0001P6-2U@vcs.savannah.gnu.org>
2015-07-08  3:44   ` [Emacs-diffs] scratch/project 106e023: Add new `project' package, and use it in xref Stefan Monnier
2015-07-08 13:13     ` Dmitry Gutov
2015-07-08 14:06       ` Stefan Monnier [this message]
2015-07-09  2:05         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1tgisq16.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.