From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change Date: Sat, 24 Oct 2015 09:57:45 -0400 Message-ID: References: <20151023200751.16225.35237@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445695104 10114 80.91.229.3 (24 Oct 2015 13:58:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Oct 2015 13:58:24 +0000 (UTC) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 24 15:58:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpzKU-0004b6-OM for ged-emacs-devel@m.gmane.org; Sat, 24 Oct 2015 15:57:54 +0200 Original-Received: from localhost ([::1]:44474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpzKT-0003s3-Oq for ged-emacs-devel@m.gmane.org; Sat, 24 Oct 2015 09:57:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpzKQ-0003ry-RM for emacs-devel@gnu.org; Sat, 24 Oct 2015 09:57:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpzKN-0002Uz-HW for emacs-devel@gnu.org; Sat, 24 Oct 2015 09:57:50 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:54473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpzKN-0002Ut-CM; Sat, 24 Oct 2015 09:57:47 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t9ODvjEk000531; Sat, 24 Oct 2015 09:57:46 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 88260662C5; Sat, 24 Oct 2015 09:57:45 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Fri, 23 Oct 2015 20:07:52 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5469=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5469> : inlines <3953> : streams <1526654> : uri <2069424> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192538 Archived-At: > * src/xdisp.c (redisplay_internal): Avoid inflooping when > redisplaying the selected window sets the selected frame's > redisplay flag. (Bug#21745) Thanks. Could you include in a comment a precise description of the inf-loop? Reading the new code along with the above commit message I'm left wondering exactly what was the problem: was a single redisplay inf-looping (if so, where?), or was one redisplay immediately causing another redisplay (if so, why do the subsequent redisplays still set the selected frame's redisplay flag)? Stefan