From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21701: Fwd: cl-typecase broken (was 25.0.50; ert explainer for equal can't handle negative numbers) Date: Fri, 04 Dec 2015 08:30:47 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449235888 11215 80.91.229.3 (4 Dec 2015 13:31:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Dec 2015 13:31:28 +0000 (UTC) Cc: 21701-done@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 04 14:31:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a4qS7-0003Xw-Bt for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Dec 2015 14:31:11 +0100 Original-Received: from localhost ([::1]:40828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qS6-0003rA-Hh for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Dec 2015 08:31:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qS2-0003qr-E0 for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 08:31:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4qRz-0000aR-4e for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 08:31:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qRz-0000aL-1S for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 08:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a4qRy-000518-QK for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2015 08:31:02 -0500 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Dec 2015 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 21701@debbugs.gnu.org, monnier@iro.umontreal.ca, andlind@gmail.com Original-Received: via spool by 21701-done@debbugs.gnu.org id=D21701.144923585219267 (code D ref 21701); Fri, 04 Dec 2015 13:31:02 +0000 Original-Received: (at 21701-done) by debbugs.gnu.org; 4 Dec 2015 13:30:52 +0000 Original-Received: from localhost ([127.0.0.1]:38353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4qRn-00050h-S1 for submit@debbugs.gnu.org; Fri, 04 Dec 2015 08:30:52 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:8690) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4qRk-00050X-VL for 21701-done@debbugs.gnu.org; Fri, 04 Dec 2015 08:30:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CvCwA731xV/yr292hcgxCEAsEMCYR+gk0EAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBYwwqFQjgjuBWyCCeAEBAQ X-IPAS-Result: A0CvCwA731xV/yr292hcgxCEAsEMCYR+gk0EAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBYwwqFQjgjuBWyCCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="184470266" Original-Received: from 104-247-246-42.cpe.teksavvy.com (HELO pastel.home) ([104.247.246.42]) by ironport2-out.teksavvy.com with ESMTP; 04 Dec 2015 08:30:47 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DCB85614D1; Fri, 4 Dec 2015 08:30:47 -0500 (EST) In-Reply-To: (Anders Lindgren's message of "Fri, 4 Dec 2015 13:18:49 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109582 Archived-At: > I just realised that the underlying problem is a change to `cl-typecase'. > It treats -50 as a character. > > (cl-typecase -50 > (character "A character") > (fixnum "A fixnum") > (t "Something else")) > > Emacs 25 returns "A character" and emacs 24 "A fixnum". I installed the patch below which should fix this. Stefan diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 09d2d3f..c8aad3a 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -2885,7 +2885,7 @@ cl--macroexp-fboundp (put 'real 'cl-deftype-satisfies #'numberp) (put 'fixnum 'cl-deftype-satisfies #'integerp) (put 'base-char 'cl-deftype-satisfies #'characterp) -(put 'character 'cl-deftype-satisfies #'integerp) +(put 'character 'cl-deftype-satisfies #'natnump) ;;;###autoload