From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#22107: 25.1; Wrong docstring for this-single-command-keys Date: Tue, 08 Dec 2015 23:53:05 -0500 Message-ID: References: <87h9jt3o66.fsf@gmail.com> <838u54dgg2.fsf@gnu.org> <83mvtkb882.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449696743 18879 80.91.229.3 (9 Dec 2015 21:32:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Dec 2015 21:32:23 +0000 (UTC) Cc: 22107@debbugs.gnu.org, bruce.connor.am@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 09 22:32:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a6mLM-0004el-U1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Dec 2015 22:32:13 +0100 Original-Received: from localhost ([::1]:37917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6mLM-00013F-1a for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Dec 2015 16:32:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6mLH-00011M-O3 for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2015 16:32:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6mLD-0002X1-7x for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2015 16:32:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6mLD-0002Wx-3x for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2015 16:32:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1a6mLC-0002ao-VL for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2015 16:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2015 21:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22107 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22107-submit@debbugs.gnu.org id=B22107.14496966759896 (code B ref 22107); Wed, 09 Dec 2015 21:32:02 +0000 Original-Received: (at 22107) by debbugs.gnu.org; 9 Dec 2015 21:31:15 +0000 Original-Received: from localhost ([127.0.0.1]:38151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a6mKQ-0002ZT-UF for submit@debbugs.gnu.org; Wed, 09 Dec 2015 16:31:15 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:32134) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a6mKP-0002Z7-Vv for 22107@debbugs.gnu.org; Wed, 09 Dec 2015 16:31:14 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A6FgA731xV/yr292hcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAScvIxALNBIUGA0kiDcIzyMBAQEBAQUBAQEBAR2LOoUFB4QtBYwwkmeSFINZI4IKHIFwIIJ4AQEB X-IPAS-Result: A0A6FgA731xV/yr292hcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAScvIxALNBIUGA0kiDcIzyMBAQEBAQUBAQEBAR2LOoUFB4QtBYwwkmeSFINZI4IKHIFwIIJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="184819165" Original-Received: from 104-247-246-42.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.246.42]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Dec 2015 23:53:05 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 1B988AE064; Tue, 8 Dec 2015 23:53:05 -0500 (EST) In-Reply-To: <83mvtkb882.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Dec 2015 05:40:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109813 Archived-At: >> > diff --git a/src/keyboard.c b/src/keyboard.c >> > index 02bc7d2..e378b89 100644 >> > --- a/src/keyboard.c >> > +++ b/src/keyboard.c >> > @@ -1486,8 +1486,11 @@ command_loop_1 (void) >> > if (!CONSP (last_command_event)) >> > kset_last_repeatable_command (current_kboard, Vreal_this_command); >> > >> > - this_command_key_count = 0; >> > - this_single_command_key_start = 0; >> > + if (NILP (KVAR (current_kboard, Vprefix_arg))) >> > + { >> > + this_command_key_count = 0; >> > + this_single_command_key_start = 0; >> > + } >> > >> > if (current_kboard->immediate_echo >> > && !NILP (call0 (Qinternal_echo_keystrokes_prefix))) >> >> My gut feeling is that this isn't quite right, because the new approach >> basically never does anything special for Vprefix_arg (the overarching >> design goal is to make prefix-arg completely non-special, to the point >> where it should be possible to move it to Elisp, save for its use in >> `interactive', IIRC). > Bu the futzing with these indices cannot be done from Lisp, so what's > the alternative? Maybe your patch is OK but just needs to be changed so that instead of checking prefix-arg we check "NILP (call0 (Qinternal_echo_keystrokes_prefix))". Stefan