From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22107@debbugs.gnu.org, bruce.connor.am@gmail.com
Subject: bug#22107: 25.1; Wrong docstring for this-single-command-keys
Date: Tue, 08 Dec 2015 23:53:05 -0500 [thread overview]
Message-ID: <jwv1tawfd5b.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83mvtkb882.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Dec 2015 05:40:13 +0200")
>> > diff --git a/src/keyboard.c b/src/keyboard.c
>> > index 02bc7d2..e378b89 100644
>> > --- a/src/keyboard.c
>> > +++ b/src/keyboard.c
>> > @@ -1486,8 +1486,11 @@ command_loop_1 (void)
>> > if (!CONSP (last_command_event))
>> > kset_last_repeatable_command (current_kboard, Vreal_this_command);
>> >
>> > - this_command_key_count = 0;
>> > - this_single_command_key_start = 0;
>> > + if (NILP (KVAR (current_kboard, Vprefix_arg)))
>> > + {
>> > + this_command_key_count = 0;
>> > + this_single_command_key_start = 0;
>> > + }
>> >
>> > if (current_kboard->immediate_echo
>> > && !NILP (call0 (Qinternal_echo_keystrokes_prefix)))
>>
>> My gut feeling is that this isn't quite right, because the new approach
>> basically never does anything special for Vprefix_arg (the overarching
>> design goal is to make prefix-arg completely non-special, to the point
>> where it should be possible to move it to Elisp, save for its use in
>> `interactive', IIRC).
> Bu the futzing with these indices cannot be done from Lisp, so what's
> the alternative?
Maybe your patch is OK but just needs to be changed so that instead of
checking prefix-arg we check "NILP (call0
(Qinternal_echo_keystrokes_prefix))".
Stefan
next prev parent reply other threads:[~2015-12-09 4:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 15:42 bug#22107: 25.1; Wrong docstring for this-single-command-keys Artur Malabarba
2015-12-07 18:10 ` Glenn Morris
2015-12-07 21:46 ` Artur Malabarba
2015-12-07 21:55 ` Glenn Morris
2015-12-07 22:10 ` Artur Malabarba
2015-12-08 1:20 ` Glenn Morris
2015-12-08 12:01 ` Artur Malabarba
2015-12-08 16:59 ` Eli Zaretskii
2015-12-09 3:28 ` Stefan Monnier
[not found] ` <83mvtkb882.fsf@gnu.org>
2015-12-09 4:53 ` Stefan Monnier [this message]
[not found] ` <83io47blbq.fsf@gnu.org>
2015-12-10 18:34 ` Stefan Monnier
2015-12-10 18:37 ` Stefan Monnier
2015-12-10 18:50 ` Eli Zaretskii
2015-12-11 4:17 ` Stefan Monnier
[not found] ` <83eget8gos.fsf@gnu.org>
2015-12-11 14:49 ` Stefan Monnier
[not found] ` <83poyd6m1b.fsf@gnu.org>
2015-12-12 3:57 ` Stefan Monnier
2015-12-12 4:28 ` Stefan Monnier
2015-12-12 7:55 ` Eli Zaretskii
2015-12-12 14:25 ` Stefan Monnier
2015-12-12 14:55 ` Eli Zaretskii
2015-12-12 23:34 ` John Wiegley
2015-12-13 4:16 ` Stefan Monnier
2015-12-13 10:12 ` Artur Malabarba
2015-12-13 15:37 ` Eli Zaretskii
2015-12-13 20:53 ` Artur Malabarba
2015-12-14 3:27 ` Eli Zaretskii
2015-12-14 13:52 ` Artur Malabarba
2015-12-13 15:53 ` Stefan Monnier
2015-12-13 17:25 ` Drew Adams
2015-12-13 20:15 ` Stefan Monnier
2020-09-07 15:26 ` Lars Ingebrigtsen
2020-10-07 4:10 ` Lars Ingebrigtsen
2015-12-10 18:49 ` Eli Zaretskii
2015-12-11 4:24 ` Stefan Monnier
[not found] ` <83bn9x8g12.fsf@gnu.org>
2015-12-11 14:47 ` Stefan Monnier
2015-12-11 4:17 ` Stefan Monnier
2015-12-11 13:10 ` Artur Malabarba
2015-12-11 14:44 ` Stefan Monnier
2015-12-11 15:39 ` Artur Malabarba
2015-12-12 4:06 ` Stefan Monnier
2016-05-11 13:33 ` bug#22107: this-command-keys no longer returns prefix argument Kaushal Modi
2016-05-11 14:02 ` Eli Zaretskii
2016-05-11 14:08 ` Kaushal Modi
2016-05-11 14:22 ` Stefan Monnier
2016-05-13 11:52 ` Kaushal Modi
2016-05-13 14:10 ` Eli Zaretskii
2016-05-13 15:00 ` Kaushal Modi
2016-05-11 14:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1tawfd5b.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=22107@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.