From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Alan Mackenzie <acm@muc.de>
Cc: yary <not.com@gmail.com>,
23407@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#23407: .dir-local settings get obliterated on running a major mode function.
Date: Thu, 05 May 2016 08:54:00 -0400 [thread overview]
Message-ID: <jwv1t5gacuy.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <20160505113925.GB1950@acm.fritz.box> (Alan Mackenzie's message of "Thu, 5 May 2016 11:39:25 +0000")
>> (setq-local hack-local-variables--done t)
>> in hack-local-variables, and then testing that instead of testing
>> delay-mode-hooks?
> That's even more horrible.
Huh? It makes it clear what's going on: the find-file part of the code
wants to make sure that hack-local-variables is called, so
hack-local-variables sets a var when it's called, and find-file checks
it to know whether that's been done or not.
It's reliable and contrary to the code you had, it doesn't need to care
about packages unrelated to find-file nor to hack-local-variables, nor
about variables which are similarly unrelated to find-file nor to
hack-local-variables.
Stefan
next prev parent reply other threads:[~2016-05-05 12:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 10:27 bug#23407: .dir-local settings get obliterated on running a major mode function Alan Mackenzie
2016-04-30 10:53 ` Dmitry Gutov
2016-04-30 18:50 ` Glenn Morris
2016-04-30 18:53 ` Glenn Morris
2016-05-01 21:28 ` Alan Mackenzie
2016-05-02 4:02 ` Stefan Monnier
2016-05-02 7:10 ` Alan Mackenzie
2016-05-03 18:10 ` Stefan Monnier
2016-05-05 11:39 ` Alan Mackenzie
2016-05-05 12:54 ` Stefan Monnier [this message]
[not found] ` <mailman.1598.1462012164.7477.bug-gnu-emacs@gnu.org>
2016-05-05 11:24 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1t5gacuy.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23407@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=dgutov@yandex.ru \
--cc=not.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.