From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master cf17576 4/7: Fix #89: Make sure compilation-auto-jump run before cleanup Date: Sat, 01 Oct 2016 23:05:11 -0400 Message-ID: References: <20161002014727.17588.95168@vcs.savannah.gnu.org> <20161002014727.C847C22016A@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1475377567 24768 195.159.176.226 (2 Oct 2016 03:06:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2016 03:06:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Leo Liu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 02 05:06:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqX6C-00054K-4E for ged-emacs-devel@m.gmane.org; Sun, 02 Oct 2016 05:05:56 +0200 Original-Received: from localhost ([::1]:57841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqX6A-0003wo-7m for ged-emacs-devel@m.gmane.org; Sat, 01 Oct 2016 23:05:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqX5a-0003wR-Bf for emacs-devel@gnu.org; Sat, 01 Oct 2016 23:05:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqX5V-00031s-9W for emacs-devel@gnu.org; Sat, 01 Oct 2016 23:05:17 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:17107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqX5V-00031b-5s for emacs-devel@gnu.org; Sat, 01 Oct 2016 23:05:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AyBwALW9BX/4Pjr2xdGwEBAQMBAQGDLQEBAQEBHh45fYJ5hVCvdoIDJIUuRAQCAoFpOhMBAgEBAQEBAQFeJ4RiAQEEViMQCzQSFBgNUogvDrxHAQEBAQEFAQEBASOKfYUMhRAFmVmGIotXhxSGC4hdhjCBPiADMYMbgVEghgoBAQE X-IPAS-Result: A0AyBwALW9BX/4Pjr2xdGwEBAQMBAQGDLQEBAQEBHh45fYJ5hVCvdoIDJIUuRAQCAoFpOhMBAgEBAQEBAQFeJ4RiAQEEViMQCzQSFBgNUogvDrxHAQEBAQEFAQEBASOKfYUMhRAFmVmGIotXhxSGC4hdhjCBPiADMYMbgVEghgoBAQE X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="274295429" Original-Received: from 108-175-227-131.dsl.teksavvy.com (HELO ceviche.home) ([108.175.227.131]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 01 Oct 2016 23:05:12 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 06CF766218; Sat, 1 Oct 2016 23:05:11 -0400 (EDT) In-Reply-To: <20161002014727.C847C22016A@vcs.savannah.gnu.org> (Leo Liu's message of "Sun, 2 Oct 2016 01:47:27 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207935 Archived-At: > + ;; Manually run the `compilation-auto-jump' timer. Hackish but > + ;; everything else seems unreliable. See: > + ;; > + ;; - http://debbugs.gnu.org/13829 > + ;; - http://debbugs.gnu.org/23987 > + ;; - https://github.com/leoliu/ggtags/issues/89 > + ;; > + (pcase (cl-find 'compilation-auto-jump timer-list :key #'timer--function) > + (`nil ) > + (timer (timer-event-handler timer))) I think this deserves a bug report, where we try to figure out how to make it possible for ggtags.el to work properly without resorting to such a hideous and brittle hack. A hack will probably have to stay for compatibility with older Emacsen, but we should come up with a better solution for the future. Stefan