From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Date: Sun, 18 Dec 2016 15:15:21 -0500 Message-ID: References: <20161212202151.21054.37035@vcs.savannah.gnu.org> <20161212202152.428192201BB@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482092139 26972 195.159.176.226 (18 Dec 2016 20:15:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Dec 2016 20:15:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 18 21:15:35 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIhrq-0005f7-K4 for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2016 21:15:34 +0100 Original-Received: from localhost ([::1]:42034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIhrr-0001uc-Tb for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2016 15:15:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIhrl-0001uL-B8 for emacs-devel@gnu.org; Sun, 18 Dec 2016 15:15:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIhri-0005Te-8c for emacs-devel@gnu.org; Sun, 18 Dec 2016 15:15:29 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIhri-0005T8-3J for emacs-devel@gnu.org; Sun, 18 Dec 2016 15:15:26 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id uBIKFLHK006485; Sun, 18 Dec 2016 15:15:22 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C9653AE3F6; Sun, 18 Dec 2016 15:15:21 -0500 (EST) In-Reply-To: (Philipp Stephani's message of "Sun, 18 Dec 2016 19:43:54 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5892=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5892> : inlines <5581> : streams <1725227> : uri <2342920> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210609 Archived-At: > For some of them definitely. I'd draw the line between pure functions like > car and eq, where those facilities never make sense and would be > ineffective anyway as the functions are compiled away or called directly, > and impure functions like call-process, where fset is necessary for > mocking. As a rule of thumb, I'd suggest to ban fset on all symbols that > have a byte-code equivalent, and on constant symbols. I still very doubt that the potential benefit is worth the added cost (more specifically, as a maintainer I would strongly oppose such measure). Are you also going to try and prevent the user from using all the other ways he can shoot himself in the foot? Stefan