From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Stefan Monnier <monnier@iro.umontreal.ca>
Newsgroups: gmane.emacs.help
Subject: Re: Seeking Advice about refactoring and advice snippet
Date: Fri, 10 Feb 2017 14:55:17 -0500
Message-ID: <jwv1sv525c3.fsf-monnier+gmane.emacs.help@gnu.org>
References: <CAEwkUWMyyUhBtdJ+vL=JmOR00N5MzzX84peqzPSyMy90hS0v=A@mail.gmail.com>
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: blaine.gmane.org 1486756556 25610 195.159.176.226 (10 Feb 2017 19:55:56 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 10 Feb 2017 19:55:56 +0000 (UTC)
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
To: help-gnu-emacs@gnu.org
Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Feb 10 20:55:52 2017
Return-path: <help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geh-help-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>)
	id 1ccHIM-00066x-Of
	for geh-help-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 20:55:50 +0100
Original-Received: from localhost ([::1]:45738 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>)
	id 1ccHIQ-0008Aw-U7
	for geh-help-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 14:55:54 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48126)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ccHI1-0008Ao-VM
	for help-gnu-emacs@gnu.org; Fri, 10 Feb 2017 14:55:30 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ccHHy-0007Pi-MP
	for help-gnu-emacs@gnu.org; Fri, 10 Feb 2017 14:55:30 -0500
Original-Received: from [195.159.176.226] (port=37430 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <geh-help-gnu-emacs@m.gmane.org>)
	id 1ccHHy-0007PY-Ec
	for help-gnu-emacs@gnu.org; Fri, 10 Feb 2017 14:55:26 -0500
Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ccHHq-0004Sl-07
	for help-gnu-emacs@gnu.org; Fri, 10 Feb 2017 20:55:18 +0100
X-Injected-Via-Gmane: http://gmane.org/
Original-Lines: 17
Original-X-Complaints-To: usenet@blaine.gmane.org
Cancel-Lock: sha1:pjUd3MExK+8rxwEM34/uWQ9Hbmw=
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 195.159.176.226
X-BeenThere: help-gnu-emacs@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Users list for the GNU Emacs text editor <help-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/help-gnu-emacs>,
	<mailto:help-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/help-gnu-emacs/>
List-Post: <mailto:help-gnu-emacs@gnu.org>
List-Help: <mailto:help-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/help-gnu-emacs>,
	<mailto:help-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "help-gnu-emacs"
	<help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.help:112296
Archived-At: <http://permalink.gmane.org/gmane.emacs.help/112296>

> How would you refactor that snippet to apply the dry principle?

Here's how I'd refactor it:

    (with-current-buffer (get-buffer "*scratch*")
      (add-hook 'kill-buffer-hook
                (lambda () (error "DENIED! don't kill my precious *scratch*!!"))
                nil t))

;-)


        Stefan


PS: Along the same lines: kill-this-buffer calls kill-buffer, so you
shouldn't need to advise kill-this-buffer.