From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25965: 26.0.50; iter-lambda may evaluate certain forms twice Date: Wed, 08 Mar 2017 16:52:13 -0500 Message-ID: References: <87efydcvvr.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489009993 6472 195.159.176.226 (8 Mar 2017 21:53:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2017 21:53:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25965@debbugs.gnu.org To: Andreas Politz , Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 08 22:53:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cljW4-0000js-J0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Mar 2017 22:53:04 +0100 Original-Received: from localhost ([::1]:58654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cljWA-0001hw-PN for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Mar 2017 16:53:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cljW5-0001hr-3w for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 16:53:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cljW2-0005qK-2Y for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 16:53:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48590) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cljW1-0005pz-VQ for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 16:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cljW1-0000lv-KW for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 16:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Mar 2017 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25965-submit@debbugs.gnu.org id=B25965.14890099502915 (code B ref 25965); Wed, 08 Mar 2017 21:53:01 +0000 Original-Received: (at 25965) by debbugs.gnu.org; 8 Mar 2017 21:52:30 +0000 Original-Received: from localhost ([127.0.0.1]:46789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cljVV-0000kw-W7 for submit@debbugs.gnu.org; Wed, 08 Mar 2017 16:52:30 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cljVU-0000kn-8p for 25965@debbugs.gnu.org; Wed, 08 Mar 2017 16:52:29 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v28LqD7e001782; Wed, 8 Mar 2017 16:52:13 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8AA0B6627C; Wed, 8 Mar 2017 16:52:13 -0500 (EST) In-Reply-To: <87efydcvvr.fsf@luca> (Andreas Politz's message of "Sat, 04 Mar 2017 09:02:32 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5967=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5967> : inlines <5732> : streams <1736096> : uri <2389262> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130357 Archived-At: > The unwind-protect form is created in this function. > > #+BEGIN_SRC emacs-lisp > (defun cps--make-dynamic-binding-wrapper (dynamic-var static-var) > (cl-assert lexical-binding) > (lambda (form) > `(let ((,dynamic-var ,static-var)) > (unwind-protect ; Update the static shadow after evaluation is done > ,form > (setf ,static-var ,dynamic-var)) > ,form))) > #+END_SRC > > And it seems to me that the second occurrence of ,form is just an > error. Hmm... indeed that looks odd, and maybe just removing the second ,form is the right fix. Daniel, do you happen to remember what the second ,form above is meant to do? Stefan