From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 34d4720: Electric quotes: Improve support for Markdown mode (Bug#24709) Date: Sun, 02 Jul 2017 13:48:23 -0400 Message-ID: References: <20170702154850.22058.98643@vcs0.savannah.gnu.org> <20170702154852.1796522E35@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499017749 812 195.159.176.226 (2 Jul 2017 17:49:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Jul 2017 17:49:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Philipp Stephani To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 02 19:49:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRizX-0008Ly-4U for ged-emacs-devel@m.gmane.org; Sun, 02 Jul 2017 19:49:03 +0200 Original-Received: from localhost ([::1]:58775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRizc-0002V5-Gs for ged-emacs-devel@m.gmane.org; Sun, 02 Jul 2017 13:49:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRiz1-0002Nk-7T for emacs-devel@gnu.org; Sun, 02 Jul 2017 13:48:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRiyx-0005xA-9l for emacs-devel@gnu.org; Sun, 02 Jul 2017 13:48:31 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:44364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRiyx-0005vH-41 for emacs-devel@gnu.org; Sun, 02 Jul 2017 13:48:27 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v62HmNRG027510; Sun, 2 Jul 2017 13:48:23 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 26B9066271; Sun, 2 Jul 2017 13:48:23 -0400 (EDT) In-Reply-To: <20170702154852.1796522E35@vcs0.savannah.gnu.org> (Philipp Stephani's message of "Sun, 2 Jul 2017 11:48:51 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6061=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6061> : inlines <5959> : streams <1752474> : uri <2454724> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216119 Archived-At: > Also introduce a new variable 'electric-quote-code-faces'. Major > modes such as 'markdown-mode' can add faces to this list to treat text > as inline code and disable electric quoting. Hmm... FWIW I don't like using faces for that (e.g. it means the features doesn't work when the user disables font-lock-mode, even in cases where it's easy to decide what to do based on syntax-ppss for example). Why not use a electric-quote-inhibit-function hook instead? Stefan