From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#28428: comment-search-backward with no comments Date: Fri, 22 Sep 2017 12:40:58 -0400 Message-ID: References: <87377seua8.fsf@ailuros> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506098539 21480 195.159.176.226 (22 Sep 2017 16:42:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Sep 2017 16:42:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 28428@debbugs.gnu.org To: "N. Raghavendra" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 22 18:42:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvR1n-0005EV-MO for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Sep 2017 18:42:11 +0200 Original-Received: from localhost ([::1]:60113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvR1v-0004h6-3m for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Sep 2017 12:42:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvR1j-0004cT-Bu for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2017 12:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvR1e-0004wu-Cv for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2017 12:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvR1e-0004wf-AF for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2017 12:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dvR1d-00008o-RV for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2017 12:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2017 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28428-submit@debbugs.gnu.org id=B28428.1506098463462 (code B ref 28428); Fri, 22 Sep 2017 16:42:01 +0000 Original-Received: (at 28428) by debbugs.gnu.org; 22 Sep 2017 16:41:03 +0000 Original-Received: from localhost ([127.0.0.1]:53105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvR0g-00007O-W1 for submit@debbugs.gnu.org; Fri, 22 Sep 2017 12:41:03 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvR0e-00006q-OU for 28428@debbugs.gnu.org; Fri, 22 Sep 2017 12:41:01 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8MGewid031218; Fri, 22 Sep 2017 12:40:58 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3BB5F66257; Fri, 22 Sep 2017 12:40:58 -0400 (EDT) In-Reply-To: <87377seua8.fsf@ailuros> (N. Raghavendra's message of "Tue, 12 Sep 2017 04:07:35 +0530") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6122=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6122> : inlines <6084> : streams <1764136> : uri <2504775> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137244 Archived-At: > (if (not (re-search-backward comment-start-skip limit t)) > - (unless noerror (error "No comment")) > + (progn > + (goto-char limit) > + (unless noerror (error "No comment"))) That looks fine, thank you. But I think the simpler patch below works as well: diff --git a/lisp/newcomment.el b/lisp/newcomment.el index be6dbe3a4c..e32966e596 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -524,7 +524,7 @@ comment-search-backward ;; comment-search-backward is only used to find the comment-column (in ;; comment-set-column) and to find the comment-start string (via ;; comment-beginning) in indent-new-comment-line, it should be harmless. - (if (not (re-search-backward comment-start-skip limit t)) + (if (not (re-search-backward comment-start-skip limit 'move)) (unless noerror (error "No comment")) (beginning-of-line) (let* ((end (match-end 0)) I wonder if there's code out there that depends on this behavior, tho, since AFAIK it's been behaving this way "forever". Stefan