From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el Date: Mon, 09 Oct 2017 11:57:11 -0400 Message-ID: References: <20171009134715.11038.14309@vcs0.savannah.gnu.org> <20171009134716.77ADE201F1@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507564882 10434 195.159.176.226 (9 Oct 2017 16:01:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Oct 2017 16:01:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 09 18:01:07 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1aUB-0007gj-6M for ged-emacs-devel@m.gmane.org; Mon, 09 Oct 2017 18:00:55 +0200 Original-Received: from localhost ([::1]:58520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1aUI-0003gu-Be for ged-emacs-devel@m.gmane.org; Mon, 09 Oct 2017 12:01:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1aQg-0001j4-LD for emacs-devel@gnu.org; Mon, 09 Oct 2017 11:57:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1aQf-0007w4-VW for emacs-devel@gnu.org; Mon, 09 Oct 2017 11:57:18 -0400 Original-Received: from pmta31.teksavvy.com ([76.10.157.38]:21583) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1aQc-0007tJ-2S; Mon, 09 Oct 2017 11:57:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HKKQDUm9tZ/5+ESC1dHAEBBAEBCgEBg?= =?us-ascii?q?12BUokuhHmQC5o3ChOFKAKEN0MUAQIBAQEBAQEBA2gohRkGeRALDScSFBgxikO?= =?us-ascii?q?qOSICin4BAQgCJoMtggKGLzWKeAWRQI91lmKJUSiHF5VagTk2IoEOMiEIMoVgH?= =?us-ascii?q?4IDJIogAQEB?= X-IPAS-Result: =?us-ascii?q?A2HKKQDUm9tZ/5+ESC1dHAEBBAEBCgEBg12BUokuhHmQC5o?= =?us-ascii?q?3ChOFKAKEN0MUAQIBAQEBAQEBA2gohRkGeRALDScSFBgxikOqOSICin4BAQgCJ?= =?us-ascii?q?oMtggKGLzWKeAWRQI91lmKJUSiHF5VagTk2IoEOMiEIMoVgH4IDJIogAQEB?= X-IronPort-AV: E=Sophos;i="5.42,500,1500955200"; d="scan'208";a="5799152" Original-Received: from unknown (HELO ceviche.home) ([45.72.132.159]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 11:57:12 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0459F66240; Mon, 9 Oct 2017 11:57:11 -0400 (EDT) In-Reply-To: <20171009134716.77ADE201F1@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Mon, 9 Oct 2017 09:47:16 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.38 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219309 Archived-At: > - (set (make-local-variable (car local)) > - (cdr local))))) > + ;; Cloning message-default-charset could cause an already > + ;; encoded text to be encoded again, yielding raw bytes > + ;; instead of characters in the message. > + (unless (string-match "message-default-charset" > + (symbol-name (car local))) > + (set (make-local-variable (car local)) > + (cdr local)))))) Could you add a comment explaining why we do (string-match "message-default-charset" (symbol-name (car local)) rather than (eq 'message-default-charset (car local)) -- Stefan "puzzled"