From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: AW: Re: [Emacs-diffs] master d3233b4: Make filecache use extended completion Date: Tue, 07 Nov 2017 12:19:40 -0500 Message-ID: References: <1uomdcbnbfdy7ri3rgxmixwk.1510063436659@email.android.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1510075208 19573 195.159.176.226 (7 Nov 2017 17:20:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Nov 2017 17:20:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 07 18:20:05 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC7Xf-0004p6-7R for ged-emacs-devel@m.gmane.org; Tue, 07 Nov 2017 18:20:03 +0100 Original-Received: from localhost ([::1]:54677 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC7Xl-0007sm-1I for ged-emacs-devel@m.gmane.org; Tue, 07 Nov 2017 12:20:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC7Xb-0007sQ-RB for emacs-devel@gnu.org; Tue, 07 Nov 2017 12:20:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC7XY-0002ED-Jx for emacs-devel@gnu.org; Tue, 07 Nov 2017 12:19:59 -0500 Original-Received: from [195.159.176.226] (port=57875 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eC7XY-0002D1-CW for emacs-devel@gnu.org; Tue, 07 Nov 2017 12:19:56 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eC7XM-00049R-QQ for emacs-devel@gnu.org; Tue, 07 Nov 2017 18:19:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:MPJqyVk/C6E8H3vUe5pdykvp7ug= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219968 Archived-At: > You seem pretty sure, that it isn't.  Well, I wasn't. So, I just setup file-cache and did a few tests to confirm. I pushed a corresponding patch to master. Stefan >
-------- Ursprüngliche Nachricht --------
Von: Stefan Monnier >
Datum:05.11.2017 16:05 (GMT+01:00) >
An: emacs-devel@gnu.org
Cc: Andreas Politz >
Betreff: Re: [Emacs-diffs] master > d3233b4: Make filecache use extended completion
>
> + (let* ((completion-list (completion-all-completions >> + newstring file-cache-alist nil newpoint)) >> + (base-size (cdr (last completion-list)))) >> + (when base-size >> + (setcdr (last completion-list) nil)) >> + (if (> (length completion-list) 1) >> + (progn >> + (delete-region (- (point-max) (length string)) (point-max)) >> + (save-excursion (insert newstring)) >> + (forward-char newpoint) >> + ;; Add our own setup function to the Completions Buffer >> + (let ((completion-setup-hook >> + (append completion-setup-hook >> + (list 'file-cache-completion-setup-function)))) >> + (with-output-to-temp-buffer file-cache-completions-buffer >> + (display-completion-list >> + (completion-hilit-commonality completion-list newpoint))))) > IIRC completion-all-completions already returns hilited strings (and > done with more care than what completion-hilit-commonality can do). > So is this completion-hilit-commonality call still beneficial? > Stefan