From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#31692: Emacs sometimes drops key events Date: Thu, 07 Jun 2018 11:30:58 -0400 Message-ID: References: <83wovgd2aj.fsf@gnu.org> <87po163v65.fsf@web.de> <83in6yarhe.fsf@gnu.org> <877encq5co.fsf@web.de> <8336y0x9c3.fsf@gnu.org> <87zi078r8n.fsf@web.de> <83efhiwrmj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528385649 14424 195.159.176.226 (7 Jun 2018 15:34:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Jun 2018 15:34:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , radon.neon@gmail.com, 31692@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 07 17:34:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQwvM-0003du-Mf for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 17:34:04 +0200 Original-Received: from localhost ([::1]:58667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQwxT-0007G5-Ue for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jun 2018 11:36:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQwtR-0002yQ-9n for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 11:32:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQwtO-0005QS-4L for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 11:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58661) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQwtO-0005Pu-0q for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 11:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fQwtN-0007af-Jt for bug-gnu-emacs@gnu.org; Thu, 07 Jun 2018 11:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jun 2018 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31692-submit@debbugs.gnu.org id=B31692.152838546529112 (code B ref 31692); Thu, 07 Jun 2018 15:32:01 +0000 Original-Received: (at 31692) by debbugs.gnu.org; 7 Jun 2018 15:31:05 +0000 Original-Received: from localhost ([127.0.0.1]:38325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQwsS-0007ZS-0Y for submit@debbugs.gnu.org; Thu, 07 Jun 2018 11:31:05 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQwsO-0007Yv-Qy for 31692@debbugs.gnu.org; Thu, 07 Jun 2018 11:31:02 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w57FVPWd029842; Thu, 7 Jun 2018 11:31:25 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A6526656A0; Thu, 7 Jun 2018 11:30:58 -0400 (EDT) In-Reply-To: <83efhiwrmj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Jun 2018 18:20:04 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6303=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6303> : inlines <6683> : streams <1789008> : uri <2654222> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147141 Archived-At: > @@ -3511,9 +3511,25 @@ > (let ((catch-sym (make-symbol "input"))) > `(with-local-quit > (catch ',catch-sym > - (let ((throw-on-input ',catch-sym)) > - (or (input-pending-p) > - (progn ,@body))))))) > + (let ((throw-on-input ',catch-sym) > + val) > + (setq val > + (or (input-pending-p) > + (progn ,@body))) > + (cond > + ;; If quit-flag is equal to throw-on-input, it means BODY > + ;; didn't test quit-flag, and therefore ran to completion > + ;; even though input arrived before it finished. In that > + ;; case, we must throw manually, because otherwise > + ;; quit-flag will remain set, and we get Quit to > + ;; top-level, which has undesirable consequences, such as > + ;; discarding input etc. > + ((eq quit-flag throw-on-input) > + (throw 'throw-on-input t)) > + ;; This is in case the user actually quits while BODY runs. > + (quit-flag > + nil) > + (t val))))))) I don't understand the (throw 'throw-on-input t) (throw throw-on-input t) would make more sense, but in any case we're just about to exit that `catch` so throwing won't have any real effect. I think instead of (throw 'throw-on-input t) what is needed here is (setq quit-flag nil) which will also make the body return nil (rather than t like (throw throw-on-input t) would), which I believe is also the right thing. Stefan