From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) Date: Thu, 12 Jul 2018 12:40:18 -0400 Message-ID: References: <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83in5lg4ol.fsf@gnu.org> <83efg9fxnj.fsf@gnu.org> <838t6hfa4h.fsf@gnu.org> <87h8l4lt9q.fsf@gmail.com> <831sc8fttu.fsf@gnu.org> <87a7qwzahe.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531413515 4854 195.159.176.226 (12 Jul 2018 16:38:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jul 2018 16:38:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: tzz@lifelogs.com, Eli Zaretskii , cpitclaudel@gmail.com, larsi@gnus.org, emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 12 18:38:30 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdebu-00015p-A8 for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 18:38:30 +0200 Original-Received: from localhost ([::1]:33038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdedz-0002jR-3u for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 12:40:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdedl-0002hs-Fc for emacs-devel@gnu.org; Thu, 12 Jul 2018 12:40:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdedi-0002gc-9w for emacs-devel@gnu.org; Thu, 12 Jul 2018 12:40:25 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:43820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdedh-0002fd-Uo; Thu, 12 Jul 2018 12:40:22 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6CGeIMR028902; Thu, 12 Jul 2018 12:40:18 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 56FCD660DD; Thu, 12 Jul 2018 12:40:18 -0400 (EDT) In-Reply-To: <87a7qwzahe.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Thu, 12 Jul 2018 17:26:21 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6328=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6328> : inlines <6747> : streams <1792345> : uri <2672588> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227281 Archived-At: > Perhaps it could work in emacs -Q if you make the whole feature depend > on a variable which I can set dir-locally (presumably not in Emacs, but > in all my other projects). Actually, I think it can be made to work without any customization (take the absence of a ChangeLog file as the cue). >> And having the vc-log buffer under change-log-mode is, of course, >> trivial, either with your customizations or by default. > But that in turn would lose me some useful that vc-log functionality. > AFAIU the two modes should be merged, maybe one deriving from the other. They're different: - change-log-mode handles a sequence of commit messages - it includes dates - it uses a different syntax for authorship - its entries are indented with a TAB - it doesn't know about the special first line "Subject: ". So, while I do think that some of change-log-mode's features should be made available in *vc-log* buffers, it's not just a "merge". > I think the changes envisioned above (particularly the fileless > ChangeLog buffer) only justify working on them if noone else is working > on the better alternative, which is IMO to automatically generate the "* > file.ext (changed entity)" list from the diff at commit-preparation > time, as I think someone suggested already. AFAIK the two issues are orthogonal/complementary: ChangeLog files are being phased out pretty much everywhere, AFAIK, so while we'll probably want change-log-mode to keep supporting them for the foreseeable future, we do want to adapt it to the newer use case where similar entries are recorded in the commit log rather than in a file. BTW, there's diff-add-change-log-entries-other-window (bound to `C-x 4 A` in diff-mode) which already tries to create the list of entries from the diff. [ It turns out it's not as easy as it seems to make it work well :-( ] Stefan