From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Tests involving post-command-hook Date: Wed, 01 Aug 2018 07:51:06 -0400 Message-ID: References: <87bmangip8.fsf@gmx.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533124170 18573 195.159.176.226 (1 Aug 2018 11:49:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Aug 2018 11:49:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 01 13:49:26 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkpd7-0004it-Q5 for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2018 13:49:25 +0200 Original-Received: from localhost ([::1]:39175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkpfD-0003k1-16 for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2018 07:51:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkpey-0003fm-G0 for emacs-devel@gnu.org; Wed, 01 Aug 2018 07:51:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkpet-0000hO-Ld for emacs-devel@gnu.org; Wed, 01 Aug 2018 07:51:20 -0400 Original-Received: from [195.159.176.226] (port=44714 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkpet-0000fN-DL for emacs-devel@gnu.org; Wed, 01 Aug 2018 07:51:15 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fkpck-0004J0-Fn for emacs-devel@gnu.org; Wed, 01 Aug 2018 13:49:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:QhG/96A2GYdZ5zmc7fxC+VgrTvg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228080 Archived-At: > I'm using ERT to test for the hl-line face property and it appears that > in the test environment, the function hl-line-highlight is not > automatically run from post-command-hook as it should be, although I use > call-interactively to mimic a command invocation. It works only if I pre/post-command-hook is run by the command *loop*, not by call-interactively. The command loop is the chunk of C code which does something like: (while t (let ((keys (read-key-sequence))) (run-hooks 'pre-command-hook) (call-interactively (key-binding keys)) (run-hooks 'post-command-hook) (redisplay))) We don't want call-interactively to run those hooks, because commands may internally call call-interactively themselves. Stefan