From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Line height issues with display-line-number-mode Date: Wed, 08 May 2019 09:39:58 -0400 Message-ID: References: <6fd496f0-7dd5-6c0e-5121-b618e7dca831@gmail.com> <83sgtqi02k.fsf@gnu.org> <83r29ahyz2.fsf@gnu.org> <83pnouhwxs.fsf@gnu.org> <83ef59igzc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="94748"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 15:40:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOMoV-000OPq-Ad for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 15:40:51 +0200 Original-Received: from localhost ([127.0.0.1]:37402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOMoU-00077K-5Y for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 09:40:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOMni-00076z-6p for emacs-devel@gnu.org; Wed, 08 May 2019 09:40:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOMnh-0000eT-BZ for emacs-devel@gnu.org; Wed, 08 May 2019 09:40:02 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:39611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOMnh-0000dW-6e; Wed, 08 May 2019 09:40:01 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x48DdwBb000792; Wed, 8 May 2019 09:39:58 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 90B556ABF4; Wed, 8 May 2019 09:39:58 -0400 (EDT) In-Reply-To: <83ef59igzc.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 May 2019 09:43:19 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6542=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6542> : inlines <7074> : streams <1820931> : uri <2841956> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236286 Archived-At: > Btw, any reasons (other than "because we can") why we use these > tricks, instead of actually producing an underline? Not sure what "producing an underline" means concretely. All I tried to do in *vc-log* (aka log-edit-mode) is to represent the separation between the header and the body in a "graphical" (as opposed to purely textual) way. The current implementation is just something that works, but we could of course change it. > when we produce line numbers, so that we start the layout of the rest > of the line with the height of, say, 1 pixel, and let the rest of the > line's text enlarge that as needed. But doing this na=EFvely would > backfire with various special cases, like empty lines, lines with > characters whose font-provided height is small, etc.: those lines will > appear smaller in height, Smaller than what? AFAICT they wouldn't appear any smaller than when line-numbers are turned off, or would they? Stefan