From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "Eric S. Raymond" <esr@thyrsus.com>
Subject: Re: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.
Date: Sun, 26 May 2019 18:40:10 -0400 [thread overview]
Message-ID: <jwv1s0krgfq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20190525172357.86D4F207F5@vcs0.savannah.gnu.org> (Eric S. Raymond's message of "Sat, 25 May 2019 13:23:56 -0400 (EDT)")
> -;;; startup.el --- process Emacs shell arguments -*- lexical-binding: t -*-
> +;; startup.el --- process Emacs shell arguments -*- lexical-binding: t -*-
This is an error, it should be 3 semi-colons.
> +(defun find-init-path (fn)
> + "Look in ~/.config/FOO or ~/.FOO for the dotfile or dot directory FOO.
> +It is expected that the output will undergo ~ expansion. Implements the
> +XDG convention for dotfiles."
> + (let* ((xdg-path (concat "~" init-file-user "/.config/" fn))
> + (oldstyle-path (concat "~" init-file-user "/." fn))
> + (found-path (if (file-exists-p xdg-path) xdg-path oldstyle-path)))
> + found-path))
AFAICT this is only used during startup and hence shouldn't have such
an "official sounding" name. It could/should use a "startup--" prefix,
for example.
Furthermore it shouldn't say "path" but "filename" to follow our
naming convention.
Stefan
next parent reply other threads:[~2019-05-26 22:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190525172356.30070.65317@vcs0.savannah.gnu.org>
[not found] ` <20190525172357.86D4F207F5@vcs0.savannah.gnu.org>
2019-05-26 22:40 ` Stefan Monnier [this message]
2019-06-03 2:32 ` [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config Eli Zaretskii
2019-06-09 7:01 ` [PATCH] Implement XDG Base Directory specification for user-emacs-directory (was: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.) Amin Bandali
2019-06-09 8:10 ` Eli Zaretskii
2019-06-09 18:59 ` [PATCH] Implement XDG Base Directory specification for user-emacs-directory Stefan Monnier
2019-06-09 19:16 ` Eli Zaretskii
2019-06-09 20:16 ` Noam Postavsky
2019-06-10 16:22 ` Eli Zaretskii
2019-06-10 18:55 ` Noam Postavsky
2019-06-10 19:21 ` Lars Ingebrigtsen
2019-06-10 19:26 ` Eli Zaretskii
2019-07-02 16:55 ` Noam Postavsky
2019-07-02 17:26 ` Eli Zaretskii
2019-07-23 14:36 ` Eli Zaretskii
2019-07-27 2:58 ` Amin Bandali
2019-07-27 7:55 ` Eli Zaretskii
2019-07-27 18:46 ` Paul Eggert
2019-07-27 21:22 ` Basil L. Contovounesios
2019-07-28 14:41 ` Eli Zaretskii
2019-07-28 15:21 ` Basil L. Contovounesios
2019-07-28 16:34 ` Eli Zaretskii
2019-07-28 14:48 ` Eli Zaretskii
2019-07-29 1:00 ` Elias Mårtenson
2019-07-29 2:36 ` Eli Zaretskii
2019-07-29 4:24 ` Elias Mårtenson
2019-07-29 14:21 ` Eli Zaretskii
2019-08-25 8:46 ` Eli Zaretskii
2019-08-27 21:50 ` Paul Eggert
2019-08-28 5:59 ` Eli Zaretskii
2019-09-01 1:24 ` bug#583: " Paul Eggert
2019-06-13 11:34 ` [PATCH] Implement XDG Base Directory specification for user-emacs-directory (was: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.) Stefan Kangas
2019-05-25 19:47 [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config Eli Zaretskii
2019-05-26 13:13 ` Amin Bandali
2019-05-26 13:51 ` Stefan Monnier
2019-05-26 14:49 ` Eli Zaretskii
2019-05-26 22:17 ` Amin Bandali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1s0krgfq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.